Add an e2e-ish test for the Upload flow #613
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 97.59% 97.66% +0.06%
==========================================
Files 431 433 +2
Lines 36152 36245 +93
==========================================
+ Hits 35283 35399 +116
+ Misses 869 846 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 97.59% 97.66% +0.06%
==========================================
Files 431 433 +2
Lines 36152 36245 +93
==========================================
+ Hits 35283 35399 +116
+ Misses 869 846 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 97.63% 98.07% +0.43%
==========================================
Files 466 409 -57
Lines 37358 29294 -8064
==========================================
- Hits 36475 28729 -7746
+ Misses 883 565 -318
Flags with carried forward coverage won't be shown. Click here to find out more.
see 269 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 97.59% 97.66% +0.06%
==========================================
Files 431 433 +2
Lines 36152 36245 +93
==========================================
+ Hits 35283 35399 +116
+ Misses 869 846 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Swatinem
force-pushed
the
swatinem/e2e-upload
branch
from
4fa6c4d to
d1b643e
Compare
Instead of relying on overly mocked unit tests, this rather adds a mostly end-to-end test. It Pushes uploads to Storage/Redis, and then invokes the `Upload` task, running it to completion. After completion of the whole upload flow, it runs assertions on the final report after all processing is complete.
Swatinem
force-pushed
the
swatinem/e2e-upload
branch
from
d1b643e to
0bc6f48
Compare
There was a problem hiding this comment.
LGTM, I think we should merge this verison now.
I'd like to also add some considerations for "future work"
What happened to the notifications? There was a task scheduled and the requests likely failed... we might want to verify that in the future?
There are some inner details on the reports we have had issues with in the past (particularly around the sessions), it would be something else that we might add more asserts into.
The carryforward logic would benefit from having an e2e test for it as well I believe
Yes, I believe I saw some log output mentioning that those failed.
Totally agree that it makes sense to add more parts to this test, or introduce more similar tests. |
Instead of relying on overly mocked unit tests, this rather adds a mostly end-to-end test. It Pushes uploads to Storage/Redis, and then invokes the
Uploadtask, running it to completion. After completion of the whole upload flow, it runs assertions on the final report after all processing is complete.