Simplify retries of build_report_from_raw_content
#618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes and inlines the `schedule_for_later_try` call, and adjusts the tests accordingly
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 97.66% 97.66% -0.01%
==========================================
Files 433 433
Lines 36245 36224 -21
==========================================
- Hits 35399 35378 -21
Misses 846 846
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 97.66% 97.66% -0.01%
==========================================
Files 433 433
Lines 36245 36224 -21
==========================================
- Hits 35399 35378 -21
Misses 846 846
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 97.66% 97.66% -0.01%
==========================================
Files 433 433
Lines 36245 36224 -21
==========================================
- Hits 35399 35378 -21
Misses 846 846
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 97.70% 97.70% -0.01%
==========================================
Files 468 468
Lines 37451 37430 -21
==========================================
- Hits 36591 36570 -21
Misses 860 860
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes and inlines the
schedule_for_later_trycall, and adjusts the tests accordingly