Test analytics seats checking #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function will determine whether the PR author needs to have their seat activation given an EnrichedPull object. This function is being added because we want to add seat activation checking for bundle analysis and test analytics.
I want to be able to optionally pass the pull and repo_service to the classes extending BaseNotifier during construction and I also want the notifiers to not run the functions to get the pull and repo_service if they already exist on the object.
we want to check if a pr author's seat needs to be activated when we're notifying test results
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 98.11% 98.08% -0.04%
==========================================
Files 437 437
Lines 36727 36826 +99
==========================================
+ Hits 36034 36120 +86
- Misses 693 706 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 98.11% 98.08% -0.04%
==========================================
Files 437 437
Lines 36727 36826 +99
==========================================
+ Hits 36034 36120 +86
- Misses 693 706 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 98.11% 98.08% -0.04%
==========================================
Files 437 437
Lines 36727 36826 +99
==========================================
+ Hits 36034 36120 +86
- Misses 693 706 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 98.15% 98.13% -0.03%
==========================================
Files 476 476
Lines 38048 38158 +110
==========================================
+ Hits 37347 37445 +98
- Misses 701 713 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes This change has been scanned for critical changes. Learn more |
Swatinem
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #622
Fixes: codecov/engineering-team#2264
we want to check if a pr author's seat needs to be activated when
we're notifying test results
also refactors some BaseNotifier stuff so the seat checking is easier