fix: make sure code block has copy button #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36565 36580 +15
=======================================
+ Hits 35884 35899 +15
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36565 36580 +15
=======================================
+ Hits 35884 35899 +15
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36565 36580 +15
=======================================
+ Hits 35884 35899 +15
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 98.15% 98.16%
=======================================
Files 473 473
Lines 37770 37785 +15
=======================================
+ Hits 37075 37090 +15
Misses 695 695
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
❌ 4 Tests Failed:
View the top 2 failed tests by shortest run time
View the full list of 1 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Swatinem
approved these changes
Aug 16, 2024
| @@ -351,7 +351,7 @@ def test_upload_finisher_task_call( | |||
| assert expected_result == result | |||
| mock_repo_provider_comments.post_comment.assert_called_with( | |||
| pull.pullid, | |||
| "### :x: 4 Tests Failed:\n| Tests completed | Failed | Passed | Skipped |\n|---|---|---|---|\n| 4 | 4 | 0 | 0 |\n<details><summary>View the top 3 failed tests by shortest run time</summary>\n\n> <pre>\n> test_name1\n> </pre>\n> <details><summary>Stack Traces | 2s run time</summary>\n> \n> > <pre>Shared failure message</pre>\n> > [View](https://example.com/build_url_1) the CI Build\n> \n> </details>\n\n\n> <pre>\n> Other Class Name\x1ftest_name2\n> </pre>\n> <details><summary>Stack Traces | 3s run time</summary>\n> \n> > <pre>Shared failure message</pre>\n> > [View](https://example.com/build_url_2) the CI Build\n> \n> </details>\n\n\n> <pre>\n> Class Name\x1ftest_name0\n> </pre>\n> <details><summary>Stack Traces | 4s run time</summary>\n> \n> > <pre><pre>Fourth <br><br></pre> | test | instance |</pre>\n> > [View](https://example.com/build_url_3) the CI Build\n> \n> </details>\n\n</details>\n\nTo view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/joseph-sentry/codecov-demo/tests/main)", | |||
| "### :x: 4 Tests Failed:\n| Tests completed | Failed | Passed | Skipped |\n|---|---|---|---|\n| 4 | 4 | 0 | 0 |\n<details><summary>View the top 3 failed tests by shortest run time</summary>\n\n> ```\n> test_name1\n> ```\n> <details><summary>Stack Traces | 2s run time</summary>\n> \n> > ```\n> > Shared \n> > \n> > \n> > \n> > <pre> \n> > \n> > \n> > | test | test | test </pre>failure message\n> > ```\n> > [View](https://example.com/build_url_1) the CI Build\n> \n> </details>\n\n\n> ```\n> Other Class Name test_name2\n> ```\n> <details><summary>Stack Traces | 3s run time</summary>\n> \n> > ```\n> > Shared \n> > \n> > \n> > \n> > <pre> \n> > \n> > \n> > | test | test | test </pre>failure message\n> > ```\n> > [View](https://example.com/build_url_2) the CI Build\n> \n> </details>\n\n\n> ```\n> Class Name test_name0\n> ```\n> <details><summary>Stack Traces | 4s run time</summary>\n> \n> > ```\n> > <pre>Fourth \n> > \n> > </pre> | test | instance |\n> > ```\n> > [View](https://example.com/build_url_3) the CI Build\n> \n> </details>\n\n</details>\n\nTo view individual test run time comparison to the main branch, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/test-username/test-repo-name/tests/main)", | |||
There was a problem hiding this comment.
these snapshots are pretty impossible to review. can you format them as multiline strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.