bundle analysis: compare with stored compareSha if applicable #626
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 440 440
Lines 36719 36764 +45
=======================================
+ Hits 36035 36080 +45
Misses 684 684
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 440 440
Lines 36719 36764 +45
=======================================
+ Hits 36035 36080 +45
Misses 684 684
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 440 440
Lines 36719 36764 +45
=======================================
+ Hits 36035 36080 +45
Misses 684 684
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 475 475
Lines 37924 37969 +45
=======================================
+ Hits 37227 37272 +45
Misses 697 697
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
requirements.in
Outdated
| @@ -1,5 +1,5 @@ | |||
| https://github.com/codecov/opentelem-python/archive/refs/tags/v0.0.4a1.tar.gz#egg=codecovopentelem | |||
| https://github.com/codecov/shared/archive/76a3263079150e47059a3b08c7ef3a29e7e78cf4.tar.gz#egg=shared | |||
There was a problem hiding this comment.
to be updated once the Shared PR merges to main
| @@ -118,25 +118,48 @@ async def initialize_and_save_report( | |||
| db_session.flush() | |||
| return commit_report | |||
|
|
|||
There was a problem hiding this comment.
Refactor this a little bit, instead of having _previous_bundle_analysis_report fetch the commit to use then fetch the BA report, it will call _get_parent_commit to fetch the commit. _get_parent_commit function will try to select the "premerge commit" if available in the head BA report if not default back to selecting commit.parent.
services/bundle_analysis/new_notify/contexts/tests/test_commit_status_context.py
Show resolved
Hide resolved
For PR Comments of BA, when doing a comparison, try to find the base commit of the head commit based on the stored custom compareSha in the bundle report first, if not found default back to using commit.parent.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.