Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete and gitignore .DS_Store #627

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Delete and gitignore .DS_Store #627

merged 1 commit into from
Aug 26, 2024

Conversation

Swatinem
Copy link
Contributor

This is some internal file created by MacOS Finder which should definitely be ignored in repos.

I have seen one was accidentally committed recently, so this cleans that up again.

This is some internal file created by MacOS Finder which should definitely be ignored in repos.

I have seen one was accidentally committed recently, so this cleans that up again.
@Swatinem Swatinem requested a review from a team August 16, 2024 08:44
@Swatinem Swatinem self-assigned this Aug 16, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         438      438           
  Lines       36565    36565           
=======================================
  Hits        35884    35884           
  Misses        681      681           
Flag Coverage Δ
integration 98.13% <ø> (ø)
latest-uploader-overall 98.13% <ø> (ø)
unit 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.11% <ø> (ø)
OutsideTasks 98.11% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (201323d) to head (615e6f9).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         438      438           
  Lines       36565    36565           
=======================================
  Hits        35884    35884           
  Misses        681      681           
Flag Coverage Δ
integration 98.13% <ø> (ø)
latest-uploader-overall 98.13% <ø> (ø)
unit 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.11% <ø> (ø)
OutsideTasks 98.11% <ø> (ø)

Copy link

codecov-public-qa bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (201323d) to head (615e6f9).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         438      438           
  Lines       36565    36565           
=======================================
  Hits        35884    35884           
  Misses        681      681           
Flag Coverage Δ
integration 98.13% <ø> (ø)
latest-uploader-overall 98.13% <ø> (ø)
unit 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.11% <ø> (ø)
OutsideTasks 98.11% <ø> (ø)

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (201323d) to head (615e6f9).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files         473      473           
  Lines       37770    37770           
=======================================
  Hits        37075    37075           
  Misses        695      695           
Flag Coverage Δ
integration 98.13% <ø> (ø)
latest-uploader-overall 98.13% <ø> (ø)
unit 98.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.15% <ø> (ø)
OutsideTasks 98.11% <ø> (ø)

This change has been scanned for critical changes. Learn more

@Swatinem Swatinem added this pull request to the merge queue Aug 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2024
@Swatinem Swatinem added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 438000b Aug 26, 2024
26 checks passed
@Swatinem Swatinem deleted the swatinem/rm-dsstore branch August 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants