fix: add user_plan to apply_async options #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were previously calling get_user_plan_from_task_name twice, and this function makes a database call which slows things down. This commit makes it so we call it once in apply_async and pass the value we get back through to the custom task router function.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36565 36567 +2
=======================================
+ Hits 35884 35886 +2
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36565 36567 +2
=======================================
+ Hits 35884 35886 +2
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36565 36567 +2
=======================================
+ Hits 35884 35886 +2
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 98.15% 98.16%
=======================================
Files 473 473
Lines 37770 37772 +2
=======================================
+ Hits 37075 37077 +2
Misses 695 695
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Swatinem
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were previously calling get_user_plan_from_task_name twice, and this function makes a database call which slows things down.
This commit makes it so we call it once in apply_async and pass the value we get back through to the custom task router function.
Fixes: codecov/engineering-team#2258