chore: reduce log level for step failed #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we fail to create the notification context we can't send that notification, but that is not an error. So warning should suffice to aid in debugging. Typically this happens when some information is missing. For example, a commit that is not part of a PR will fail to build the PR_COMMENT notification context, simply because there is no PR associated with the commit.
JerrySentry
approved these changes
Aug 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 98.13% 98.13% -0.01%
==========================================
Files 440 440
Lines 36720 36719 -1
==========================================
- Hits 36037 36036 -1
Misses 683 683
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #634 +/- ##
=========================================
+ Coverage 0 98.13% +98.13%
=========================================
Files 0 440 +440
Lines 0 36719 +36719
=========================================
+ Hits 0 36036 +36036
- Misses 0 683 +683
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 98.13% 98.13% -0.01%
==========================================
Files 440 440
Lines 36720 36719 -1
==========================================
- Hits 36037 36036 -1
Misses 683 683
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 98.16% 98.16% -0.01%
==========================================
Files 475 475
Lines 37925 37924 -1
==========================================
- Hits 37228 37227 -1
Misses 697 697
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fail to create the notification context we can't send that
notification, but that is not an error. So warning should suffice to aid in
debugging.
Typically this happens when some information is missing.
For example, a commit that is not part of a PR will fail to build the PR_COMMENT
notification context, simply because there is no PR associated with the commit.