Don't auto create bucket when not needed. #647
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 98.12% 98.11% -0.02%
==========================================
Files 437 437
Lines 36778 36780 +2
==========================================
- Hits 36090 36088 -2
- Misses 688 692 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 98.12% 98.11% -0.02%
==========================================
Files 437 437
Lines 36778 36780 +2
==========================================
- Hits 36090 36088 -2
- Misses 688 692 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 98.12% 98.11% -0.02%
==========================================
Files 437 437
Lines 36778 36780 +2
==========================================
- Hits 36090 36088 -2
- Misses 688 692 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 98.16% 98.16% -0.01%
==========================================
Files 476 476
Lines 38099 38101 +2
==========================================
Hits 37401 37401
- Misses 698 700 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
| @@ -72,10 +72,16 @@ def setup_worker(): | |||
| storage_client = get_storage_client() | |||
There was a problem hiding this comment.
This is causing issues with GCS rate limits on calling bucket create. We know the bucket exists already.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.