Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require BASE report for patch in comparison #650

Merged
merged 1 commit into from
Aug 28, 2024

fix: don't require BASE report for patch in comparison

4c2518c
Select commit
Loading
Failed to load commit list.
Merged

fix: don't require BASE report for patch in comparison #650

fix: don't require BASE report for patch in comparison
4c2518c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 28, 2024 in 0s

98.17% (+0.01%) compared to 14faefc

View this Pull Request on Codecov

98.17% (+0.01%) compared to 14faefc

Details

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.17%. Comparing base (14faefc) to head (4c2518c).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
tasks/compute_comparison.py 97.43% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   98.16%   98.17%   +0.01%     
==========================================
  Files         476      476              
  Lines       38072    38639     +567     
==========================================
+ Hits        37374    37935     +561     
- Misses        698      704       +6     
Components Coverage Δ
NonTestCode 96.14% <97.82%> (-0.02%) ⬇️
OutsideTasks 98.09% <100.00%> (-0.03%) ⬇️
Files Coverage Δ
services/comparison/__init__.py 97.41% <100.00%> (+0.06%) ⬆️
tasks/tests/unit/test_compute_comparison.py 100.00% <100.00%> (ø)
tasks/compute_comparison.py 99.37% <97.43%> (-0.63%) ⬇️

... and 9 files with indirect coverage changes

Related Entrypoints
run/app.tasks.compute_comparison.ComputeComparison