Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sentry SDK to latest #651

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Update Sentry SDK to latest #651

merged 1 commit into from
Aug 29, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Aug 28, 2024

This also changes all the imports/usage to use sentry_sdk rather than more focused imports.


Probably depends on codecov/shared#338

@Swatinem Swatinem requested a review from a team August 28, 2024 12:49
@Swatinem Swatinem self-assigned this Aug 28, 2024
@Swatinem Swatinem force-pushed the swatinem/bump-sentry-sdk branch from d6bc83b to ce0ec8d Compare August 28, 2024 12:55
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (aea8367) to head (19eedbf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   98.10%   98.10%   -0.01%     
==========================================
  Files         476      476              
  Lines       38170    38129      -41     
==========================================
- Hits        37447    37406      -41     
  Misses        723      723              
Flag Coverage Δ
integration 98.05% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.05% <100.00%> (-0.01%) ⬇️
unit 98.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.06% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/bundle_analysis/report.py 100.00% <100.00%> (ø)
services/failure_normalizer.py 100.00% <100.00%> (ø)
services/flake_detection.py 95.90% <100.00%> (ø)
...ervices/notification/notifiers/comment/__init__.py 99.42% <100.00%> (ø)
services/report/parser/__init__.py 100.00% <100.00%> (ø)
services/report/report_processor.py 94.52% <100.00%> (ø)
tasks/process_flakes.py 100.00% <100.00%> (ø)
tasks/test_results_finisher.py 94.67% <100.00%> (ø)
tasks/test_results_processor.py 99.31% <100.00%> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)
... and 1 more
Related Entrypoints
run/app.tasks.test_results.TestResultsFinisherTask
run/app.tasks.test_results.TestResultsProcessor

@codecov-staging
Copy link

codecov-staging bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   98.05%   98.05%   -0.01%     
==========================================
  Files         437      437              
  Lines       36849    36808      -41     
==========================================
- Hits        36134    36093      -41     
  Misses        715      715              
Flag Coverage Δ
integration 98.05% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.05% <100.00%> (-0.01%) ⬇️
unit 98.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.06% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
services/bundle_analysis/report.py 100.00% <100.00%> (ø)
services/failure_normalizer.py 100.00% <100.00%> (ø)
services/flake_detection.py 95.90% <100.00%> (ø)
...ervices/notification/notifiers/comment/__init__.py 99.42% <100.00%> (ø)
services/report/parser/__init__.py 100.00% <100.00%> (ø)
services/report/report_processor.py 94.52% <100.00%> (ø)
tasks/process_flakes.py 100.00% <100.00%> (ø)
tasks/test_results_finisher.py 94.08% <100.00%> (ø)
tasks/test_results_processor.py 99.31% <100.00%> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)
... and 1 more

@codecov-qa
Copy link

codecov-qa bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (aea8367) to head (19eedbf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   98.05%   98.05%   -0.01%     
==========================================
  Files         437      437              
  Lines       36849    36808      -41     
==========================================
- Hits        36134    36093      -41     
  Misses        715      715              
Flag Coverage Δ
integration 98.05% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.05% <100.00%> (-0.01%) ⬇️
unit 98.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.06% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/bundle_analysis/report.py 100.00% <100.00%> (ø)
services/failure_normalizer.py 100.00% <100.00%> (ø)
services/flake_detection.py 95.90% <100.00%> (ø)
...ervices/notification/notifiers/comment/__init__.py 99.42% <100.00%> (ø)
services/report/parser/__init__.py 100.00% <100.00%> (ø)
services/report/report_processor.py 94.52% <100.00%> (ø)
tasks/process_flakes.py 100.00% <100.00%> (ø)
tasks/test_results_finisher.py 94.08% <100.00%> (ø)
tasks/test_results_processor.py 99.31% <100.00%> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)
... and 1 more

Copy link

codecov-public-qa bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (aea8367) to head (19eedbf).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   98.05%   98.05%   -0.01%     
==========================================
  Files         437      437              
  Lines       36849    36808      -41     
==========================================
- Hits        36134    36093      -41     
  Misses        715      715              
Flag Coverage Δ
integration 98.05% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.05% <100.00%> (-0.01%) ⬇️
unit 98.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.06% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
services/bundle_analysis/report.py 100.00% <100.00%> (ø)
services/failure_normalizer.py 100.00% <100.00%> (ø)
services/flake_detection.py 95.90% <100.00%> (ø)
...ervices/notification/notifiers/comment/__init__.py 99.42% <100.00%> (ø)
services/report/parser/__init__.py 100.00% <100.00%> (ø)
services/report/report_processor.py 94.52% <100.00%> (ø)
tasks/process_flakes.py 100.00% <100.00%> (ø)
tasks/test_results_finisher.py 94.08% <100.00%> (ø)
tasks/test_results_processor.py 99.31% <100.00%> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)
... and 1 more

@Swatinem Swatinem force-pushed the swatinem/bump-sentry-sdk branch 2 times, most recently from 42bab2a to 93a7d0b Compare August 28, 2024 14:56
Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Swatinem Swatinem force-pushed the swatinem/bump-sentry-sdk branch from 93a7d0b to 76dd511 Compare August 29, 2024 10:58
This also changes all the imports/usage to use `sentry_sdk` rather than more focused imports
@Swatinem Swatinem force-pushed the swatinem/bump-sentry-sdk branch from 76dd511 to 19eedbf Compare August 29, 2024 10:59
@Swatinem Swatinem added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit b67b75e Aug 29, 2024
22 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/bump-sentry-sdk branch August 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants