Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared + add signals related changes I forgot in previous PRs #652

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

adrian-codecov
Copy link
Contributor

@adrian-codecov adrian-codecov commented Aug 28, 2024

Updating shared to latest + adding a minor change from last PR #649 I forgot 🙃.

Shared changes include:

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #652   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         437      437           
  Lines       36849    36849           
=======================================
  Hits        36134    36134           
  Misses        715      715           
Flag Coverage Δ
integration 98.05% <ø> (ø)
latest-uploader-overall 98.05% <ø> (ø)
unit 98.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <ø> (ø)
OutsideTasks 98.06% <ø> (ø)
Files Coverage Δ
database/events.py 93.75% <ø> (ø)
database/tests/unit/test_events.py 100.00% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (612dd94) to head (8f22ba0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #652   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         437      437           
  Lines       36849    36849           
=======================================
  Hits        36134    36134           
  Misses        715      715           
Flag Coverage Δ
integration 98.05% <ø> (ø)
latest-uploader-overall 98.05% <ø> (ø)
unit 98.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <ø> (ø)
OutsideTasks 98.06% <ø> (ø)
Files with missing lines Coverage Δ
database/events.py 93.75% <ø> (ø)
database/tests/unit/test_events.py 100.00% <ø> (ø)

Copy link

codecov-public-qa bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (612dd94) to head (8f22ba0).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #652   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         437      437           
  Lines       36849    36849           
=======================================
  Hits        36134    36134           
  Misses        715      715           
Flag Coverage Δ
integration 98.05% <ø> (ø)
latest-uploader-overall 98.05% <ø> (ø)
unit 98.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <ø> (ø)
OutsideTasks 98.06% <ø> (ø)
Files Coverage Δ
database/events.py 93.75% <ø> (ø)
database/tests/unit/test_events.py 100.00% <ø> (ø)

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (612dd94) to head (8f22ba0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #652   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files         476      476           
  Lines       38170    38170           
=======================================
  Hits        37447    37447           
  Misses        723      723           
Flag Coverage Δ
integration 98.05% <ø> (ø)
latest-uploader-overall 98.05% <ø> (ø)
unit 98.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <ø> (ø)
OutsideTasks 98.06% <ø> (ø)
Files with missing lines Coverage Δ
database/events.py 93.75% <ø> (ø)
database/tests/unit/test_events.py 100.00% <ø> (ø)

This change has been scanned for critical changes. Learn more

@adrian-codecov adrian-codecov added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit aea8367 Aug 28, 2024
25 of 26 checks passed
@adrian-codecov adrian-codecov deleted the 334_v2_adjust_installation_key branch August 28, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants