Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add database events to be executed #653

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

adrian-codecov
Copy link
Contributor

We have @events running in worker for whenever a repository is changed - these sync the data bw postgres db and shelter. While those are defined, those are never ran/acknowledged unless you import them, hence, this pr

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         437      437           
  Lines       36884    36885    +1     
=======================================
+ Hits        36172    36173    +1     
  Misses        712      712           
Flag Coverage Δ
integration 98.06% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.06% <100.00%> (+<0.01%) ⬆️
unit 98.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.06% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/engine.py 95.74% <100.00%> (+0.09%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (1a56eea) to head (88b6ffc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         437      437           
  Lines       36884    36885    +1     
=======================================
+ Hits        36172    36173    +1     
  Misses        712      712           
Flag Coverage Δ
integration 98.06% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.06% <100.00%> (+<0.01%) ⬆️
unit 98.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.06% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 95.74% <100.00%> (+0.09%) ⬆️

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (1a56eea) to head (88b6ffc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         476      476           
  Lines       38205    38206    +1     
=======================================
+ Hits        37485    37486    +1     
  Misses        720      720           
Flag Coverage Δ
integration 98.06% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.06% <100.00%> (+<0.01%) ⬆️
unit 98.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.05% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.06% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 97.87% <100.00%> (+0.04%) ⬆️

This change has been scanned for critical changes. Learn more

Copy link

codecov-public-qa bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (1a56eea) to head (88b6ffc).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         437      437           
  Lines       36884    36885    +1     
=======================================
+ Hits        36172    36173    +1     
  Misses        712      712           
Flag Coverage Δ
integration 98.06% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.06% <100.00%> (+<0.01%) ⬆️
unit 98.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.06% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/engine.py 95.74% <100.00%> (+0.09%) ⬆️

@adrian-codecov adrian-codecov added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 894f2b3 Aug 29, 2024
25 of 26 checks passed
@adrian-codecov adrian-codecov deleted the 170-add-events-to-app branch August 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants