fix: type casting #656
Merged
fix: type casting #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 437 437
Lines 36808 36814 +6
=======================================
+ Hits 36093 36099 +6
Misses 715 715
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 437 437
Lines 36808 36814 +6
=======================================
+ Hits 36093 36099 +6
Misses 715 715
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 476 476
Lines 38129 38135 +6
=======================================
+ Hits 37406 37412 +6
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 437 437
Lines 36808 36814 +6
=======================================
+ Hits 36093 36099 +6
Misses 715 715
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I was expecting that returning a certain type from yaml validation would keep the type. Maybe there's some to-from dict transformation happening but the type is being lost, and then re-casting it is not giving the expected results. So I'm improving the function to make sure that `["percentage",["absolute",1000.0]]` won't be returned anymore. Fixes Sentry issue 5767825563
giovanni-guidini
force-pushed
the
gio/fix-type-casting
branch
from
cd0b9e8
to
15db225
Compare
Swatinem
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was expecting that returning a certain type from yaml validation would keep the type.
Maybe there's some to-from dict transformation happening but the type is being lost,
and then re-casting it is not giving the expected results.
So I'm improving the function to make sure that
["percentage",["absolute",1000.0]]won't be returned anymore.Fixes Sentry issue 5767825563