Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force patch coverage totals to be float in the DB #657

Merged
merged 2 commits into from
Aug 29, 2024
Merged

force patch coverage totals to be float in the DB #657

merged 2 commits into from
Aug 29, 2024

Conversation

giovanni-guidini
Copy link
Contributor

No description provided.

@codecov-staging
Copy link

codecov-staging bot commented Aug 29, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         437      437           
  Lines       36808    36808           
=======================================
  Hits        36093    36093           
  Misses        715      715
Flag Coverage Δ
integration 98.05% <ø> (ø)
latest-uploader-overall 98.05% <ø> (ø)
unit 98.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <ø> (ø)
OutsideTasks 98.06% <ø> (ø)
Files Coverage Δ
tasks/compute_comparison.py 99.37% <ø> (ø)
tasks/tests/unit/test_compute_comparison.py 100.00% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (b67b75e) to head (7797da1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         437      437           
  Lines       36808    36808           
=======================================
  Hits        36093    36093           
  Misses        715      715
Flag Coverage Δ
integration 98.05% <ø> (ø)
latest-uploader-overall 98.05% <ø> (ø)
unit 98.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <ø> (ø)
OutsideTasks 98.06% <ø> (ø)
Files with missing lines Coverage Δ
tasks/compute_comparison.py 99.37% <ø> (ø)
tasks/tests/unit/test_compute_comparison.py 100.00% <ø> (ø)

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (b67b75e) to head (7797da1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files         476      476           
  Lines       38129    38129           
=======================================
  Hits        37406    37406           
  Misses        723      723
Flag Coverage Δ
integration 98.05% <ø> (ø)
latest-uploader-overall 98.05% <ø> (ø)
unit 98.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <ø> (ø)
OutsideTasks 98.06% <ø> (ø)
Files with missing lines Coverage Δ
tasks/compute_comparison.py 99.37% <ø> (ø)
tasks/tests/unit/test_compute_comparison.py 100.00% <ø> (ø)

This change has been scanned for critical changes. Learn more

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (b67b75e) to head (7797da1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         437      437           
  Lines       36808    36808           
=======================================
  Hits        36093    36093           
  Misses        715      715
Flag Coverage Δ
integration 98.05% <ø> (ø)
latest-uploader-overall 98.05% <ø> (ø)
unit 98.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <ø> (ø)
OutsideTasks 98.06% <ø> (ø)
Files Coverage Δ
tasks/compute_comparison.py 99.37% <ø> (ø)
tasks/tests/unit/test_compute_comparison.py 100.00% <ø> (ø)

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@giovanni-guidini giovanni-guidini added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 1a36862 Aug 29, 2024
25 of 26 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/patch-as-float branch August 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JerrySentry JerrySentry JerrySentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovanni-guidini @JerrySentry