170 2 adjust event only to fire when due #664
Conversation
…ent-only-to-fire-when-due
| @@ -140,6 +140,7 @@ class Repository(CodecovBaseModel): | |||
| random.choice(string.ascii_uppercase + string.digits) for _ in range(10) | |||
| ), | |||
| ) | |||
| upload_token = Column(postgresql.UUID) | |||
There was a problem hiding this comment.
Nothing crazy here, we've had this field in postgres for a while, just never tracked it in worker
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36699 36706 +7
=======================================
+ Hits 35993 36000 +7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36699 36706 +7
=======================================
+ Hits 35993 36000 +7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36699 36706 +7
=======================================
+ Hits 35993 36000 +7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 474 474
Lines 38025 38032 +7
=======================================
+ Hits 37311 37318 +7
Misses 714 714
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This reverts commit 853534a.
We use events to trigger calls to gcp. I'm modifying the events function only to fire when certain fields of interest change. Otherwise, we're hammering the google's api a bunch, which we don't need to
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.