Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: extend upload e2e test #665

Merged
merged 1 commit into from
Aug 30, 2024
Merged

tests: extend upload e2e test #665

merged 1 commit into from
Aug 30, 2024

Conversation

giovanni-guidini
Copy link
Contributor

Extends the upload e2e test to also take into account the Comparison
that is generated when the commit is part of a PR.

Extends the upload e2e test to also take into account the Comparison
that is generated when the commit is part of a PR.
@codecov-notifications
Copy link

codecov-notifications bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   97.93%   97.94%           
=======================================
  Files         437      437           
  Lines       36864    36899   +35     
=======================================
+ Hits        36104    36139   +35     
  Misses        760      760           
Flag Coverage Δ
integration 97.94% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.94% <100.00%> (+<0.01%) ⬆️
unit 97.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.62% <ø> (ø)
OutsideTasks 98.03% <ø> (ø)
Files Coverage Δ
tasks/tests/integration/test_upload_e2e.py 100.00% <100.00%> (ø)
tasks/tests/utils.py 100.00% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (26de857) to head (ffebf59).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   97.93%   97.94%           
=======================================
  Files         437      437           
  Lines       36864    36899   +35     
=======================================
+ Hits        36104    36139   +35     
  Misses        760      760           
Flag Coverage Δ
integration 97.94% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.94% <100.00%> (+<0.01%) ⬆️
unit 97.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.62% <ø> (ø)
OutsideTasks 98.03% <ø> (ø)
Files with missing lines Coverage Δ
tasks/tests/integration/test_upload_e2e.py 100.00% <100.00%> (ø)
tasks/tests/utils.py 100.00% <ø> (ø)

Copy link

codecov-public-qa bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (26de857) to head (ffebf59).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   97.93%   97.94%           
=======================================
  Files         437      437           
  Lines       36864    36899   +35     
=======================================
+ Hits        36104    36139   +35     
  Misses        760      760           
Flag Coverage Δ
integration 97.94% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.94% <100.00%> (+<0.01%) ⬆️
unit 97.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.62% <ø> (ø)
OutsideTasks 98.03% <ø> (ø)
Files Coverage Δ
tasks/tests/integration/test_upload_e2e.py 100.00% <100.00%> (ø)
tasks/tests/utils.py 100.00% <ø> (ø)

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (26de857) to head (ffebf59).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   97.98%   97.99%           
=======================================
  Files         476      476           
  Lines       38185    38220   +35     
=======================================
+ Hits        37417    37452   +35     
  Misses        768      768           
Flag Coverage Δ
integration 97.94% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.94% <100.00%> (+<0.01%) ⬆️
unit 97.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.74% <ø> (ø)
OutsideTasks 98.03% <ø> (ø)
Files with missing lines Coverage Δ
tasks/tests/integration/test_upload_e2e.py 100.00% <100.00%> (ø)
tasks/tests/utils.py 100.00% <ø> (ø)

This change has been scanned for critical changes. Learn more

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🎉

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 748d759 Aug 30, 2024
25 of 26 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/extend-e2e-test branch August 30, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants