Tune mypy strictness settings
#675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 433 433
Lines 36742 36742
=======================================
Hits 36040 36040
Misses 702 702
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 433 433
Lines 36742 36742
=======================================
Hits 36040 36040
Misses 702 702
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 433 433
Lines 36742 36742
=======================================
Hits 36040 36040
Misses 702 702
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 475 475
Lines 38097 38097
=======================================
Hits 37385 37385
Misses 712 712
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Swatinem
force-pushed
the
swatinem/mypy
branch
from
6e0ecb9
to
9ae27ba
Compare
In particular, this does not require files to be fully typed anymore. I also added a couple of TODOs for checks we would want to eventually enable.
Swatinem
force-pushed
the
swatinem/mypy
branch
from
9ae27ba
to
0bd6afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this does not require files to be fully typed anymore.
I also added a couple of TODOs for checks we would want to eventually enable.
I now end up with the following, which on the surface looks quite bad:
There is quite some errors related to untyped imports.
sharedcan be resolved by adding apy.typedfile I guess.Other dependencies would probably require typing stubs to be installed?
Then there is a ton of errors which look legit and should be fixed.
Otherwise this hits the limits of "I am not a python developer" :-D