-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server_default value to avoid null tokens #680
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #680 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36721 36728 +7
=======================================
+ Hits 36015 36022 +7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #680 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36721 36728 +7
=======================================
+ Hits 36015 36022 +7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #680 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36721 36728 +7
=======================================
+ Hits 36015 36022 +7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 474 474
Lines 38047 38054 +7
=======================================
+ Hits 37333 37340 +7
Misses 714 714
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
The revert of this PR, #678. Additional change includes adding a server_default=FetchedValue() to prevent upload_tokens having a null value
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.