bundle analysis: skip save measurement if no uploads #681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 98.07% 98.08%
=======================================
Files 434 434
Lines 36728 36743 +15
=======================================
+ Hits 36022 36038 +16
+ Misses 706 705 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 98.07% 98.08%
=======================================
Files 434 434
Lines 36728 36743 +15
=======================================
+ Hits 36022 36038 +16
+ Misses 706 705 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 98.07% 98.08%
=======================================
Files 434 434
Lines 36728 36743 +15
=======================================
+ Hits 36022 36038 +16
+ Misses 706 705 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 474 474
Lines 38054 38069 +15
=======================================
+ Hits 37340 37356 +16
+ Misses 714 713 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes This change has been scanned for critical changes. Learn more |
When there is no uploads for BA we will simplying not do the save measurements task, this happens when a bundle is being fully cached from a non-BA upload. A fully cached bundle doesn't need to have measurements saved for it.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.