update the signal repo function #682
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #682 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 432 432
Lines 36709 36717 +8
=======================================
+ Hits 36005 36013 +8
Misses 704 704
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #682 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 432 432
Lines 36709 36717 +8
=======================================
+ Hits 36005 36013 +8
Misses 704 704
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #682 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 432 432
Lines 36709 36717 +8
=======================================
+ Hits 36005 36013 +8
Misses 704 704
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 474 474
Lines 38065 38073 +8
=======================================
+ Hits 37351 37359 +8
Misses 714 714
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
This signal is for calling shelter's database to be in sync w/ our postgres one.
My previous implementation assumed has_changes() implied that it has "different" changes, but that's not the case. If we look for field "a" and field a went from "text_123" to "text_123", has_changes() will be set to true. Hence, this implementation actually checks that there is a change in the value itself. Plus added some logs
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.