Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shared-change-checker CI step #686

Merged
merged 1 commit into from
Sep 5, 2024
Merged

add shared-change-checker CI step #686

merged 1 commit into from
Sep 5, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Sep 5, 2024

should automatically post/update a comment on PRs that change the hash of our shared dependency for reviewers to take a quick glance at

example comment (which was updated automatically as its PR switched to different hashes for shared):
Screenshot 2024-09-04 at 5 01 02 PM

@matt-codecov matt-codecov requested a review from a team September 5, 2024 00:24
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         432      432           
  Lines       36717    36717           
=======================================
  Hits        36013    36013           
  Misses        704      704           
Flag Coverage Δ
integration 98.08% <ø> (ø)
latest-uploader-overall 98.08% <ø> (ø)
unit 98.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.07% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (141df34) to head (08e950e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         432      432           
  Lines       36717    36717           
=======================================
  Hits        36013    36013           
  Misses        704      704           
Flag Coverage Δ
integration 98.08% <ø> (ø)
latest-uploader-overall 98.08% <ø> (ø)
unit 98.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.07% <ø> (ø)

Copy link

codecov-public-qa bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (141df34) to head (08e950e).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         432      432           
  Lines       36717    36717           
=======================================
  Hits        36013    36013           
  Misses        704      704           
Flag Coverage Δ
integration 98.08% <ø> (ø)
latest-uploader-overall 98.08% <ø> (ø)
unit 98.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.07% <ø> (ø)

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (141df34) to head (08e950e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         474      474           
  Lines       38073    38073           
=======================================
  Hits        37359    37359           
  Misses        714      714           
Flag Coverage Δ
integration 98.08% <ø> (ø)
latest-uploader-overall 98.08% <ø> (ø)
unit 98.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <ø> (ø)
OutsideTasks 98.07% <ø> (ø)

This change has been scanned for critical changes. Learn more

@matt-codecov matt-codecov added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 95c7d49 Sep 5, 2024
27 checks passed
@matt-codecov matt-codecov deleted the pr686 branch September 5, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants