feat: note when bundle is cached #687

giovanni-guidini · 2024-09-05T11:49:47Z

add mention in the PR comment when bundle is cached

closes codecov/engineering-team#2045

add mention in the PR comment when bundle is cached closes codecov/engineering-team#2045

codecov-notifications · 2024-09-05T11:56:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   98.07%   98.08%           
=======================================
  Files         434      432    -2     
  Lines       36721    36725    +4     
=======================================
+ Hits        36015    36021    +6     
+ Misses        706      704    -2

Flag	Coverage Δ
integration	`98.08% <100.00%> (+<0.01%)`	⬆️
latest-uploader-overall	`98.08% <100.00%> (+<0.01%)`	⬆️
unit	`98.08% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.97% <100.00%> (+0.01%)`	⬆️
OutsideTasks	`98.07% <100.00%> (+<0.01%)`	⬆️

Files	Coverage Δ
...ervices/bundle_analysis/notify/messages/comment.py	`100.00% <100.00%> (ø)`
...ices/bundle_analysis/tests/test_bundle_analysis.py	`98.35% <100.00%> (+0.02%)`	⬆️

... and 8 files with indirect coverage changes

codecov-qa · 2024-09-05T11:56:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (9078de2) to head (0a37d11).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   98.07%   98.08%           
=======================================
  Files         434      432    -2     
  Lines       36721    36725    +4     
=======================================
+ Hits        36015    36021    +6     
+ Misses        706      704    -2

Flag	Coverage Δ
integration	`98.08% <100.00%> (+<0.01%)`	⬆️
latest-uploader-overall	`98.08% <100.00%> (+<0.01%)`	⬆️
unit	`98.08% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.97% <100.00%> (+0.01%)`	⬆️
OutsideTasks	`98.07% <100.00%> (+<0.01%)`	⬆️

Files with missing lines	Coverage Δ
...ervices/bundle_analysis/notify/messages/comment.py	`100.00% <100.00%> (ø)`
...ices/bundle_analysis/tests/test_bundle_analysis.py	`98.35% <100.00%> (+0.02%)`	⬆️

... and 8 files with indirect coverage changes

codecov-public-qa · 2024-09-05T11:57:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (9078de2) to head (0a37d11).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   98.07%   98.08%           
=======================================
  Files         434      432    -2     
  Lines       36721    36725    +4     
=======================================
+ Hits        36015    36021    +6     
+ Misses        706      704    -2

Flag	Coverage Δ
integration	`98.08% <100.00%> (+<0.01%)`	⬆️
latest-uploader-overall	`98.08% <100.00%> (+<0.01%)`	⬆️
unit	`98.08% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.97% <100.00%> (+0.01%)`	⬆️
OutsideTasks	`98.07% <100.00%> (+<0.01%)`	⬆️

Files	Coverage Δ
...ervices/bundle_analysis/notify/messages/comment.py	`100.00% <100.00%> (ø)`
...ices/bundle_analysis/tests/test_bundle_analysis.py	`98.35% <100.00%> (+0.02%)`	⬆️

... and 8 files with indirect coverage changes

codecov · 2024-09-05T11:57:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (9078de2) to head (0a37d11).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   98.12%   98.13%   +0.01%     
==========================================
  Files         474      474              
  Lines       38047    38158     +111     
==========================================
+ Hits        37333    37446     +113     
+ Misses        714      712       -2

Flag	Coverage Δ
integration	`98.08% <100.00%> (+<0.01%)`	⬆️
latest-uploader-overall	`98.08% <100.00%> (+<0.01%)`	⬆️
unit	`98.08% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`96.10% <100.00%> (+0.03%)`	⬆️
OutsideTasks	`98.07% <100.00%> (+<0.01%)`	⬆️

Files with missing lines	Coverage Δ
...ervices/bundle_analysis/notify/messages/comment.py	`100.00% <100.00%> (ø)`
...ices/bundle_analysis/tests/test_bundle_analysis.py	`98.35% <100.00%> (+0.02%)`	⬆️

... and 8 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

Swatinem · 2024-09-05T14:21:04Z

services/bundle_analysis/notify/messages/templates/bundle_analysis_notify/bundle_comment.md

+{% if bundle_rows %}{% include "bundle_analysis_notify/bundle_table.md" %}{% if has_cached %}
+ℹ️ *Bundle size includes cached data from a previous commit


Suggested change

ℹ️ *Bundle size includes cached data from a previous commit

ℹ️ *Bundle size analysis includes cached data from a previous commit

🤔 as this is an implementation detail to the bundle analysis we perform

feat: note when bundle is cached

0a37d11

add mention in the PR comment when bundle is cached closes codecov/engineering-team#2045

giovanni-guidini requested a review from a team September 5, 2024 11:49

Swatinem approved these changes Sep 5, 2024

View reviewed changes

giovanni-guidini added this pull request to the merge queue Sep 5, 2024

Merged via the queue into main with commit 31d86b6 Sep 5, 2024
26 of 27 checks passed

giovanni-guidini deleted the gio/ba-pr-comment-cached branch September 5, 2024 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: note when bundle is cached #687

feat: note when bundle is cached #687

giovanni-guidini commented Sep 5, 2024

codecov-notifications bot commented Sep 5, 2024 •

edited

Loading

codecov-qa bot commented Sep 5, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 5, 2024 •

edited

Loading

codecov bot commented Sep 5, 2024 •

edited

Loading

Swatinem Sep 5, 2024

		{% if bundle_rows %}{% include "bundle_analysis_notify/bundle_table.md" %}{% if has_cached %}
		ℹ️ *Bundle size includes cached data from a previous commit

	ℹ️ *Bundle size includes cached data from a previous commit
	ℹ️ *Bundle size analysis includes cached data from a previous commit

feat: note when bundle is cached #687

feat: note when bundle is cached #687

Conversation

giovanni-guidini commented Sep 5, 2024

codecov-notifications bot commented Sep 5, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Sep 5, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Sep 5, 2024 • edited Loading

Codecov Report

codecov bot commented Sep 5, 2024 • edited Loading

Codecov Report

Swatinem Sep 5, 2024

Choose a reason for hiding this comment

codecov-notifications bot commented Sep 5, 2024 •

edited

Loading

codecov-qa bot commented Sep 5, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 5, 2024 •

edited

Loading

codecov bot commented Sep 5, 2024 •

edited

Loading