feat: customize comment based on status #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customizes the bundle analysis PR comment based on the commit status outcome. matches designs in codecov/engineering-team#1491 except for the table warnings (we can't get a per-bundle percentage yet) Removing some unit tests in favor of larger scoped ones in `test_bundle_analysis.py`
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 433 433
Lines 36768 36771 +3
=======================================
+ Hits 36059 36063 +4
+ Misses 709 708 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 433 433
Lines 36768 36771 +3
=======================================
+ Hits 36059 36063 +4
+ Misses 709 708 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 433 433
Lines 36768 36771 +3
=======================================
+ Hits 36059 36063 +4
+ Misses 709 708 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 475 475
Lines 38124 38127 +3
=======================================
+ Hits 37405 37409 +4
+ Misses 719 718 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes This change has been scanned for critical changes. Learn more |
Swatinem
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizes the bundle analysis PR comment based on the commit status outcome. matches designs in codecov/engineering-team#1491 except for the table warnings (we can't get a per-bundle percentage yet)
Removing some unit tests in favor of larger scoped ones in
test_bundle_analysis.py