Avoid copying raw upload for parallel verification #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating a copy of a raw upload for consumption in the parallel verification task, this will only schedule parallel verification in case the uploads are not being deleted after processing. That way, the uploads are guaranteed to still be there for verification, so no copy is needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #704 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 434 434
Lines 36618 36613 -5
==========================================
- Hits 35922 35917 -5
Misses 696 696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #704 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 434 434
Lines 36618 36613 -5
==========================================
- Hits 35922 35917 -5
Misses 696 696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #704 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 434 434
Lines 36618 36613 -5
==========================================
- Hits 35922 35917 -5
Misses 696 696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 475 475
Lines 37973 37968 -5
==========================================
- Hits 37268 37263 -5
Misses 705 705
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Swatinem
force-pushed
the
swatinem/no-copy-upload
branch
from
a9a3470 to
e94e4d0
Compare
Swatinem
force-pushed
the
swatinem/no-copy-upload
branch
from
e94e4d0 to
1d25d4e
Compare
giovanni-guidini
approved these changes
Sep 16, 2024
|
Indeed. We might end up seeing some more Sentry logs about wrong report format, though I changed those to be compatible with both formats anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a copy of a raw upload for consumption in the parallel verification task, this will only schedule parallel verification in case the uploads are not being deleted after processing.
That way, the uploads are guaranteed to still be there for verification, so no copy is needed.