Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode and direnv configs #706

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add vscode and direnv configs #706

merged 1 commit into from
Sep 16, 2024

Conversation

Swatinem
Copy link
Contributor

This adds config files for direnv / pyenv.
With a system-wide install of direnv, this will automatically install and activate a .venv locally.

The vscode settings brings with it some recommended extensions, and default configuration to auto-fix/format on-save using ruff. It also recommends the mypy extension, which gives you proper underlines for type errors, which should hopefully help with fixing these and improving typing going forward.

@Swatinem Swatinem requested a review from a team September 13, 2024 10:13
@Swatinem Swatinem self-assigned this Sep 13, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         434      434           
  Lines       36607    36607           
=======================================
  Hits        35911    35911           
  Misses        696      696           
Flag Coverage Δ
integration 98.09% <ø> (ø)
latest-uploader-overall 98.09% <ø> (ø)
unit 98.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <ø> (ø)
OutsideTasks 98.10% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (e867451) to head (df4007f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         434      434           
  Lines       36607    36607           
=======================================
  Hits        35911    35911           
  Misses        696      696           
Flag Coverage Δ
integration 98.09% <ø> (ø)
latest-uploader-overall 98.09% <ø> (ø)
unit 98.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <ø> (ø)
OutsideTasks 98.10% <ø> (ø)

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (e867451) to head (df4007f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         475      475           
  Lines       37962    37962           
=======================================
  Hits        37257    37257           
  Misses        705      705           
Flag Coverage Δ
integration 98.09% <ø> (ø)
latest-uploader-overall 98.09% <ø> (ø)
unit 98.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.11% <ø> (ø)
OutsideTasks 98.10% <ø> (ø)

This change has been scanned for critical changes. Learn more

Copy link

codecov-public-qa bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (e867451) to head (df4007f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         434      434           
  Lines       36607    36607           
=======================================
  Hits        35911    35911           
  Misses        696      696           
Flag Coverage Δ
integration 98.09% <ø> (ø)
latest-uploader-overall 98.09% <ø> (ø)
unit 98.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <ø> (ø)
OutsideTasks 98.10% <ø> (ø)

This adds config files for `direnv` / `pyenv`.
With a system-wide install of `direnv`, this will automatically install and activate a `.venv` locally.

The vscode settings brings with it some recommended extensions, and default configuration to auto-fix/format on-save using `ruff`.
It also recommends the `mypy` extension, which gives you proper underlines for type errors, which should hopefully help with fixing these and improving typing going forward.
@Swatinem Swatinem added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 8e96f4d Sep 16, 2024
27 checks passed
@Swatinem Swatinem deleted the swatinem/vscode-config branch September 16, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants