Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert change stopping writing to daily_test_rollups #716

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team September 17, 2024 19:25
Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge until you see partitions in the DB pls

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
+ Coverage   97.92%   98.07%   +0.14%     
==========================================
  Files         434      434              
  Lines       36733    36734       +1     
==========================================
+ Hits        35971    36027      +56     
+ Misses        762      707      -55     
Flag Coverage Δ
integration 98.07% <100.00%> (+0.14%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+0.14%) ⬆️
unit 98.07% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (ø)
Files Coverage Δ
tasks/test_results_processor.py 98.19% <100.00%> (+0.63%) ⬆️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <ø> (+16.61%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (fa0e247) to head (3124bf5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
+ Coverage   97.92%   98.07%   +0.14%     
==========================================
  Files         434      434              
  Lines       36733    36734       +1     
==========================================
+ Hits        35971    36027      +56     
+ Misses        762      707      -55     
Flag Coverage Δ
integration 98.07% <100.00%> (+0.14%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+0.14%) ⬆️
unit 98.07% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 98.19% <100.00%> (+0.63%) ⬆️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <ø> (+16.61%) ⬆️

@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 17, 2024
Copy link

codecov-public-qa bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (fa0e247) to head (3124bf5).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
+ Coverage   97.92%   98.07%   +0.14%     
==========================================
  Files         434      434              
  Lines       36733    36734       +1     
==========================================
+ Hits        35971    36027      +56     
+ Misses        762      707      -55     
Flag Coverage Δ
integration 98.07% <100.00%> (+0.14%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+0.14%) ⬆️
unit 98.07% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (ø)
Files Coverage Δ
tasks/test_results_processor.py 98.19% <100.00%> (+0.63%) ⬆️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <ø> (+16.61%) ⬆️

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (fa0e247) to head (3124bf5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
+ Coverage   97.97%   98.12%   +0.14%     
==========================================
  Files         475      475              
  Lines       38088    38089       +1     
==========================================
+ Hits        37318    37374      +56     
+ Misses        770      715      -55     
Flag Coverage Δ
integration 98.07% <100.00%> (+0.14%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+0.14%) ⬆️
unit 98.07% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.08% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 98.19% <100.00%> (+0.63%) ⬆️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <ø> (+16.61%) ⬆️

This change has been scanned for critical changes. Learn more

Merged via the queue into main with commit e127611 Sep 17, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/revert-daily-rollup-write branch September 17, 2024 19:40
Copy link

sentry-io bot commented Sep 24, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: (psycopg2.errors.DeadlockDetected) deadlock detected app.tasks.test_results.TestResultsProcessor View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants