Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lcov parser more accepting of corrupt coverage lines #726

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Sep 19, 2024

fixes WORKER-JGW, fixes WORKER-JN4, fixes WORKER-JMY, fixes WORKER-JNY, fixes WORKER-PA7

@Swatinem Swatinem requested a review from a team September 19, 2024 13:04
@Swatinem Swatinem self-assigned this Sep 19, 2024
@Swatinem Swatinem enabled auto-merge September 19, 2024 13:06
@codecov-qa
Copy link

codecov-qa bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (95d0b4a) to head (29b1203).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/languages/lcov.py 93.87% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files         434      434              
  Lines       36764    36775      +11     
==========================================
+ Hits        36055    36065      +10     
- Misses        709      710       +1     
Flag Coverage Δ
integration 98.06% <95.00%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <95.00%> (-0.01%) ⬇️
unit 98.06% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <93.87%> (-0.01%) ⬇️
OutsideTasks 98.09% <95.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/report/languages/tests/unit/test_lcov.py 100.00% <100.00%> (ø)
services/report/languages/lcov.py 95.00% <93.87%> (-0.79%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
services/report/languages/lcov.py 93.87% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files         434      434              
  Lines       36764    36775      +11     
==========================================
+ Hits        36055    36065      +10     
- Misses        709      710       +1     
Flag Coverage Δ
integration 98.06% <95.00%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <95.00%> (-0.01%) ⬇️
unit 98.06% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <93.87%> (-0.01%) ⬇️
OutsideTasks 98.09% <95.00%> (-0.01%) ⬇️
Files Coverage Δ
services/report/languages/tests/unit/test_lcov.py 100.00% <100.00%> (ø)
services/report/languages/lcov.py 95.00% <93.87%> (-0.79%) ⬇️

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.11%. Comparing base (95d0b4a) to head (29b1203).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/languages/lcov.py 93.87% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   98.11%   98.11%   -0.01%     
==========================================
  Files         475      475              
  Lines       38119    38130      +11     
==========================================
+ Hits        37402    37412      +10     
- Misses        717      718       +1     
Flag Coverage Δ
integration 98.06% <95.00%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <95.00%> (-0.01%) ⬇️
unit 98.06% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.06% <93.87%> (-0.01%) ⬇️
OutsideTasks 98.09% <95.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/report/languages/tests/unit/test_lcov.py 100.00% <100.00%> (ø)
services/report/languages/lcov.py 95.19% <93.87%> (-0.77%) ⬇️
Related Entrypoints
run/app.tasks.upload.UploadProcessor

Copy link

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (95d0b4a) to head (29b1203).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files         434      434              
  Lines       36764    36775      +11     
==========================================
+ Hits        36055    36065      +10     
- Misses        709      710       +1     
Flag Coverage Δ
integration 98.06% <95.00%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <95.00%> (-0.01%) ⬇️
unit 98.06% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <93.87%> (-0.01%) ⬇️
OutsideTasks 98.09% <95.00%> (-0.01%) ⬇️
Files Coverage Δ
services/report/languages/tests/unit/test_lcov.py 100.00% <100.00%> (ø)
services/report/languages/lcov.py 95.00% <93.87%> (-0.79%) ⬇️

@Swatinem Swatinem added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 3c67255 Sep 19, 2024
24 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/lcov-errors branch September 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants