Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update shared #727

Merged
merged 1 commit into from
Sep 19, 2024
Merged

update shared #727

merged 1 commit into from
Sep 19, 2024

Conversation

giovanni-guidini
Copy link
Contributor

(for the changes related to InvalidInstallationError)

@github-actions GitHub Actions
Copy link

This PR includes changes to shared. Please review them here: codecov/shared@545fd04...c9d8b87

@giovanni-guidini giovanni-guidini requested a review from a team September 19, 2024 14:02
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   98.07%   98.07%   -0.01%     
==========================================
  Files         434      434              
  Lines       36776    36787      +11     
==========================================
+ Hits        36068    36078      +10     
- Misses        708      709       +1
Flag Coverage Δ
integration 98.07% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.07% <ø> (-0.01%) ⬇️
unit 98.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <ø> (-0.01%) ⬇️
OutsideTasks 98.09% <ø> (-0.01%) ⬇️

see 2 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (ff40366) to head (ee93f0e).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   98.07%   98.07%   -0.01%     
==========================================
  Files         434      434              
  Lines       36776    36787      +11     
==========================================
+ Hits        36068    36078      +10     
- Misses        708      709       +1
Flag Coverage Δ
integration 98.07% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.07% <ø> (-0.01%) ⬇️
unit 98.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <ø> (-0.01%) ⬇️
OutsideTasks 98.09% <ø> (-0.01%) ⬇️

see 2 files with indirect coverage changes

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (ff40366) to head (ee93f0e).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   98.12%   98.12%   -0.01%     
==========================================
  Files         475      475              
  Lines       38131    38178      +47     
==========================================
+ Hits        37415    37461      +46     
- Misses        716      717       +1
Flag Coverage Δ
integration 98.07% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.07% <ø> (-0.01%) ⬇️
unit 98.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.08% <ø> (+<0.01%) ⬆️
OutsideTasks 98.09% <ø> (-0.01%) ⬇️

see 2 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (ff40366) to head (ee93f0e).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   98.07%   98.07%   -0.01%     
==========================================
  Files         434      434              
  Lines       36776    36787      +11     
==========================================
+ Hits        36068    36078      +10     
- Misses        708      709       +1
Flag Coverage Δ
integration 98.07% <ø> (-0.01%) ⬇️
latest-uploader-overall 98.07% <ø> (-0.01%) ⬇️
unit 98.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <ø> (-0.01%) ⬇️
OutsideTasks 98.09% <ø> (-0.01%) ⬇️

see 2 files with indirect coverage changes

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit fea35cd Sep 19, 2024
27 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/update-shared branch September 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovanni-guidini @Swatinem