Fix flags being a list in TestResults arguments
#731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
approved these changes
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 98.09% 98.07% -0.02%
==========================================
Files 434 434
Lines 36800 36800
==========================================
- Hits 36098 36091 -7
- Misses 702 709 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 98.09% 98.07% -0.02%
==========================================
Files 434 434
Lines 36800 36800
==========================================
- Hits 36098 36091 -7
- Misses 702 709 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 98.13% 98.12% -0.02%
==========================================
Files 475 475
Lines 38155 38155
==========================================
- Hits 37445 37438 -7
- Misses 710 717 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 98.09% 98.07% -0.02%
==========================================
Files 434 434
Lines 36800 36800
==========================================
- Hits 36098 36091 -7
- Misses 702 709 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Swatinem
force-pushed
the
swatinem/testresultsflags
branch
from
cda37ed to
900ac32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #718:
Seems like
flagsis a comma-separated string in all upload types exceptTestResults, where it is already a list.Fixes ECDN-WORKER-D7C, fixes WORKER-PBY