Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix heuristic when reading flakes #732

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

we want to ignore flakes that are obvisouly tests that were broken for a bit but are now fixed

we want to ignore flakes that are obvisouly tests that were broken
for a bit but are now fixed
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36800    36805    +5     
=======================================
+ Hits        36091    36096    +5     
  Misses        709      709           
Flag Coverage Δ
integration 98.07% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+<0.01%) ⬆️
unit 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_finisher.py 93.56% <ø> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (a7cb347) to head (42ad5a8).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36800    36805    +5     
=======================================
+ Hits        36091    36096    +5     
  Misses        709      709           
Flag Coverage Δ
integration 98.07% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+<0.01%) ⬆️
unit 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_finisher.py 93.56% <ø> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (a7cb347) to head (42ad5a8).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36800    36805    +5     
=======================================
+ Hits        36091    36096    +5     
  Misses        709      709           
Flag Coverage Δ
integration 98.07% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+<0.01%) ⬆️
unit 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.09% <ø> (ø)
Files Coverage Δ
tasks/test_results_finisher.py 93.56% <ø> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (a7cb347) to head (42ad5a8).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         475      475           
  Lines       38155    38160    +5     
=======================================
+ Hits        37438    37443    +5     
  Misses        717      717           
Flag Coverage Δ
integration 98.07% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+<0.01%) ⬆️
unit 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <ø> (ø)
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_finisher.py 94.15% <ø> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@joseph-sentry joseph-sentry requested a review from a team September 25, 2024 14:00
@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 94e5edc Sep 26, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-heuristic branch September 26, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants