Create TestFlagBridge during test results processing #740
Conversation
we want to filter tests in the UI by flag, so we need a mapping from a Test and it's flags, because a Test is differentiated by its flags as well as the obvious fields (name, testsuite) when we process test results, we want to create a TestFlagBridge for every test and flag of that test
joseph-sentry
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 432 432
Lines 36273 36304 +31
=======================================
+ Hits 35570 35601 +31
Misses 703 703
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 432 432
Lines 36273 36304 +31
=======================================
+ Hits 35570 35601 +31
Misses 703 703
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 432 432
Lines 36273 36304 +31
=======================================
+ Hits 35570 35601 +31
Misses 703 703
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 432 432
Lines 36273 36304 +31
=======================================
+ Hits 35570 35601 +31
Misses 703 703
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This PR includes changes to |
tasks/test_results_processor.py
Outdated
| @@ -150,6 +182,12 @@ def _bulk_write_tests_to_db( | |||
| ) | |||
| ) | |||
|
|
|||
| test_flag_bridge_data += [ | |||
| {"test_id": test_id, "repoid": repoid, "flag_id": repo_flags[flag]} | |||
There was a problem hiding this comment.
Because test_id is not dependent on flag in flags I think we can move that outside of the list comprehension and reduce some cycles spent evaluating that for every flag right?
There was a problem hiding this comment.
at some point we'd have to turn it into a list of dicts with each value so sqlalchemy can insert it
we want to connect test objects to the RepositoryFlag objects