Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add promotional message for new message to end of PR comment #754

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

joseph-sentry
Copy link
Contributor

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@joseph-sentry joseph-sentry requested a review from a team October 2, 2024 14:51
@codecov-staging
Copy link

codecov-staging bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   98.04%   98.05%   +0.01%     
==========================================
  Files         444      444              
  Lines       35399    35451      +52     
==========================================
+ Hits        34708    34763      +55     
+ Misses        691      688       -3     
Flag Coverage Δ
integration 41.95% <20.51%> (-0.01%) ⬇️
unit 90.86% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.16% <100.00%> (+0.02%) ⬆️
OutsideTasks 95.95% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.79% <100.00%> (+<0.01%) ⬆️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (20861f4) to head (b2d7b19).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   98.04%   98.05%   +0.01%     
==========================================
  Files         444      444              
  Lines       35399    35451      +52     
==========================================
+ Hits        34708    34763      +55     
+ Misses        691      688       -3     
Flag Coverage Δ
integration 41.95% <20.51%> (-0.01%) ⬇️
unit 90.86% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.16% <100.00%> (+0.02%) ⬆️
OutsideTasks 95.95% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.79% <100.00%> (+<0.01%) ⬆️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (20861f4) to head (b2d7b19).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   98.04%   98.05%   +0.01%     
==========================================
  Files         444      444              
  Lines       35399    35451      +52     
==========================================
+ Hits        34708    34763      +55     
+ Misses        691      688       -3     
Flag Coverage Δ
integration 41.95% <20.51%> (-0.01%) ⬇️
unit 90.86% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.16% <100.00%> (+0.02%) ⬆️
OutsideTasks 95.95% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.79% <100.00%> (+<0.01%) ⬆️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (20861f4) to head (b2d7b19).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   98.04%   98.05%   +0.01%     
==========================================
  Files         444      444              
  Lines       35399    35451      +52     
==========================================
+ Hits        34708    34763      +55     
+ Misses        691      688       -3     
Flag Coverage Δ
integration 41.95% <20.51%> (-0.01%) ⬇️
unit 90.86% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.16% <100.00%> (+0.02%) ⬆️
OutsideTasks 95.95% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.79% <100.00%> (+<0.01%) ⬆️
database/tests/factories/core.py 99.39% <100.00%> (+<0.01%) ⬆️
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Copy link

github-actions bot commented Nov 12, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 03c73da Nov 18, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/new-features-comment branch November 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants