-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform parallel report merging within the Report lock #762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 98.02% 98.03%
=======================================
Files 438 438
Lines 36389 36397 +8
=======================================
+ Hits 35672 35680 +8
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 98.02% 98.03%
=======================================
Files 438 438
Lines 36389 36397 +8
=======================================
+ Hits 35672 35680 +8
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 98.02% 98.03%
=======================================
Files 438 438
Lines 36389 36397 +8
=======================================
+ Hits 35672 35680 +8
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 98.02% 98.03%
=======================================
Files 438 438
Lines 36389 36397 +8
=======================================
+ Hits 35672 35680 +8
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was an oversight in the original parallel processing PR.
The final merge step is now performed while holding the "master Report" lock to guard against concurrent mutation.