Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete intermediate report files used in parallel Processing #763

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Oct 4, 2024

This makes sure the following intermediate files are being cleaned up / deleted after parallel processing:

  • The "partial Report" files, after merging
  • The copy of the initial and the final "master Report" used in parallel verification
  • The parallel version of the "master Report" used for verification

@Swatinem Swatinem requested a review from a team October 4, 2024 09:03
@Swatinem Swatinem self-assigned this Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (35e390e) to head (13e60a7).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   98.01%   98.03%   +0.02%     
==========================================
  Files         438      438              
  Lines       36428    36447      +19     
==========================================
+ Hits        35704    35732      +28     
+ Misses        724      715       -9     
Flag Coverage Δ
integration 98.03% <100.00%> (+0.02%) ⬆️
unit 98.03% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <100.00%> (+0.06%) ⬆️
OutsideTasks 98.02% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/archive.py 99.09% <100.00%> (+0.02%) ⬆️
tasks/parallel_verification.py 92.75% <100.00%> (+13.96%) ⬆️
tasks/tests/integration/test_upload_e2e.py 100.00% <100.00%> (ø)
tasks/upload_finisher.py 96.25% <100.00%> (+0.13%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   98.01%   98.03%   +0.02%     
==========================================
  Files         438      438              
  Lines       36428    36447      +19     
==========================================
+ Hits        35704    35732      +28     
+ Misses        724      715       -9     
Flag Coverage Δ
integration 98.03% <100.00%> (+0.02%) ⬆️
unit 98.03% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <100.00%> (+0.06%) ⬆️
OutsideTasks 98.02% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/archive.py 99.09% <100.00%> (+0.02%) ⬆️
tasks/parallel_verification.py 92.75% <100.00%> (+13.96%) ⬆️
tasks/tests/integration/test_upload_e2e.py 100.00% <100.00%> (ø)
tasks/upload_finisher.py 96.25% <100.00%> (+0.13%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (35e390e) to head (13e60a7).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   98.01%   98.03%   +0.02%     
==========================================
  Files         438      438              
  Lines       36428    36447      +19     
==========================================
+ Hits        35704    35732      +28     
+ Misses        724      715       -9     
Flag Coverage Δ
integration 98.03% <100.00%> (+0.02%) ⬆️
unit 98.03% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <100.00%> (+0.06%) ⬆️
OutsideTasks 98.02% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/archive.py 99.09% <100.00%> (+0.02%) ⬆️
tasks/parallel_verification.py 92.75% <100.00%> (+13.96%) ⬆️
tasks/tests/integration/test_upload_e2e.py 100.00% <100.00%> (ø)
tasks/upload_finisher.py 96.25% <100.00%> (+0.13%) ⬆️

Copy link

codecov-public-qa bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (35e390e) to head (13e60a7).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   98.01%   98.03%   +0.02%     
==========================================
  Files         438      438              
  Lines       36428    36447      +19     
==========================================
+ Hits        35704    35732      +28     
+ Misses        724      715       -9     
Flag Coverage Δ
integration 98.03% <100.00%> (+0.02%) ⬆️
unit 98.03% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <100.00%> (+0.06%) ⬆️
OutsideTasks 98.02% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/archive.py 99.09% <100.00%> (+0.02%) ⬆️
tasks/parallel_verification.py 92.75% <100.00%> (+13.96%) ⬆️
tasks/tests/integration/test_upload_e2e.py 100.00% <100.00%> (ø)
tasks/upload_finisher.py 96.25% <100.00%> (+0.13%) ⬆️

@Swatinem Swatinem force-pushed the swatinem/delete-parallel-files branch from a5676c5 to dcfeff8 Compare October 4, 2024 09:14
This makes sure the following intermediate files are being cleaned up / deleted after parallel processing:

- The "partial Report" files, after merging
- The copy of the *initial* and the *final* "master Report" used in parallel verification
- The parallel version of the "master Report" used for verification
@Swatinem Swatinem force-pushed the swatinem/delete-parallel-files branch from dbdf280 to 13e60a7 Compare October 7, 2024 09:21
@Swatinem Swatinem added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 5340976 Oct 8, 2024
25 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/delete-parallel-files branch October 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants