-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cache monitoring in Sentry Redis integration #768
Conversation
According to https://docs.sentry.io/platforms/python/integrations/redis/#options, adding an appropriate `cache_prefix` should make sure that things get automatically populated in the Sentry "Caches" insights page. It might still be worth manually instrumenting the underlying cache code in `shared` though.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 438 438
Lines 36427 36427
=======================================
Hits 35703 35703
Misses 724 724
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 438 438
Lines 36427 36427
=======================================
Hits 35703 35703
Misses 724 724
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 438 438
Lines 36427 36427
=======================================
Hits 35703 35703
Misses 724 724
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 438 438
Lines 36427 36427
=======================================
Hits 35703 35703
Misses 724 724
Flags with carried forward coverage won't be shown. Click here to find out more.
|
According to https://docs.sentry.io/platforms/python/integrations/redis/#options, adding an appropriate
cache_prefix
should make sure that things get automatically populated in the Sentry "Caches" insights page.It might still be worth manually instrumenting the underlying cache code in
shared
though.