Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cache monitoring in Sentry Redis integration #768

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Oct 8, 2024

According to https://docs.sentry.io/platforms/python/integrations/redis/#options, adding an appropriate cache_prefix should make sure that things get automatically populated in the Sentry "Caches" insights page.

It might still be worth manually instrumenting the underlying cache code in shared though.

According to https://docs.sentry.io/platforms/python/integrations/redis/#options, adding an appropriate `cache_prefix` should make sure that things get automatically populated in the Sentry "Caches" insights page.

It might still be worth manually instrumenting the underlying cache code in `shared` though.
@Swatinem Swatinem requested a review from a team October 8, 2024 09:31
@Swatinem Swatinem self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (be5c54f) to head (a706446).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files         438      438           
  Lines       36427    36427           
=======================================
  Hits        35703    35703           
  Misses        724      724           
Flag Coverage Δ
integration 98.01% <ø> (ø)
unit 98.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.85% <ø> (ø)
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
helpers/sentry.py 76.00% <ø> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files         438      438           
  Lines       36427    36427           
=======================================
  Hits        35703    35703           
  Misses        724      724           
Flag Coverage Δ
integration 98.01% <ø> (ø)
unit 98.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.85% <ø> (ø)
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
helpers/sentry.py 76.00% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (be5c54f) to head (a706446).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files         438      438           
  Lines       36427    36427           
=======================================
  Hits        35703    35703           
  Misses        724      724           
Flag Coverage Δ
integration 98.01% <ø> (ø)
unit 98.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.85% <ø> (ø)
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
helpers/sentry.py 76.00% <ø> (ø)

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (be5c54f) to head (a706446).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files         438      438           
  Lines       36427    36427           
=======================================
  Hits        35703    35703           
  Misses        724      724           
Flag Coverage Δ
integration 98.01% <ø> (ø)
unit 98.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.85% <ø> (ø)
OutsideTasks 98.02% <ø> (ø)
Files Coverage Δ
helpers/sentry.py 76.00% <ø> (ø)

@Swatinem Swatinem added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit e0e9a5f Oct 8, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/trace-redis-cache branch October 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants