Add tracing and improve typing of NotificationService
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 438 438
Lines 36451 36460 +9
=======================================
+ Hits 35733 35742 +9
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 438 438
Lines 36451 36460 +9
=======================================
+ Hits 35733 35742 +9
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 438 438
Lines 36451 36460 +9
=======================================
+ Hits 35733 35742 +9
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 438 438
Lines 36451 36460 +9
=======================================
+ Hits 35733 35742 +9
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Adds tracing to the various `notify` implementations, and improves their typing. In particular, it fixes mismatches between the base and derived classes, and fixes up type annotations to match their usage.
Swatinem
force-pushed
the
swatinem/trace-type-notifiers
branch
from
d83aff2 to
37e2323
Compare
joseph-sentry
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tracing to the various
notifyimplementations, and improves their typing. In particular, it fixes mismatches between the base and derived classes, and fixes up type annotations to match their usage.