Cache and move load_commit_diff out of Report lock
#784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 98.01% 98.01% -0.01%
==========================================
Files 442 442
Lines 36603 36597 -6
==========================================
- Hits 35875 35869 -6
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 98.01% 98.01% -0.01%
==========================================
Files 442 442
Lines 36603 36597 -6
==========================================
- Hits 35875 35869 -6
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 98.01% 98.01% -0.01%
==========================================
Files 442 442
Lines 36603 36597 -6
==========================================
- Hits 35875 35869 -6
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 98.01% 98.01% -0.01%
==========================================
Files 442 442
Lines 36603 36597 -6
==========================================
- Hits 35875 35869 -6
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Swatinem
force-pushed
the
swatinem/cache-get-diff
branch
from
c2535a8
to
90b968b
Compare
giovanni-guidini
approved these changes
Oct 15, 2024
Swatinem
force-pushed
the
swatinem/cache-get-diff
branch
from
90b968b
to
d158dd9
Compare
Moves the `load_commit_diff` portion out of `save_report_results`. This way, the whole commit diff loading can be moved outside of the Report merge lock. Additionally, the function was decorated with a cache, as the diff for a commit will never change.
Swatinem
force-pushed
the
swatinem/cache-get-diff
branch
from
d158dd9
to
80a8138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
load_commit_diffportion out ofsave_report_results.This way, the whole commit diff loading can be moved outside of the Report merge lock. Additionally, the function was decorated with a cache, as the diff for a commit will never change.