Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for empty reports when merging #785

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

Swatinem
Copy link
Contributor

fixes WORKER-MM5

@Swatinem Swatinem requested a review from a team October 15, 2024 12:56
@Swatinem Swatinem self-assigned this Oct 15, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
services/processing/merging.py 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36601    36603       +2     
==========================================
+ Hits        35882    35883       +1     
- Misses        719      720       +1     
Flag Coverage Δ
integration 98.03% <50.00%> (-0.01%) ⬇️
unit 98.03% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <50.00%> (-0.01%) ⬇️
OutsideTasks 97.99% <50.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/processing/merging.py 92.42% <50.00%> (-1.33%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (70406db) to head (9c723bc).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/processing/merging.py 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36601    36603       +2     
==========================================
+ Hits        35882    35883       +1     
- Misses        719      720       +1     
Flag Coverage Δ
integration 98.03% <50.00%> (-0.01%) ⬇️
unit 98.03% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <50.00%> (-0.01%) ⬇️
OutsideTasks 97.99% <50.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/processing/merging.py 92.42% <50.00%> (-1.33%) ⬇️

Copy link

codecov-public-qa bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (70406db) to head (9c723bc).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36601    36603       +2     
==========================================
+ Hits        35882    35883       +1     
- Misses        719      720       +1     
Flag Coverage Δ
integration 98.03% <50.00%> (-0.01%) ⬇️
unit 98.03% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <50.00%> (-0.01%) ⬇️
OutsideTasks 97.99% <50.00%> (-0.01%) ⬇️
Files Coverage Δ
services/processing/merging.py 92.42% <50.00%> (-1.33%) ⬇️

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (70406db) to head (9c723bc).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/processing/merging.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36601    36603       +2     
==========================================
+ Hits        35882    35883       +1     
- Misses        719      720       +1     
Flag Coverage Δ
integration 98.03% <50.00%> (-0.01%) ⬇️
unit 98.03% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <50.00%> (-0.01%) ⬇️
OutsideTasks 97.99% <50.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/processing/merging.py 92.42% <50.00%> (-1.33%) ⬇️

@Swatinem Swatinem added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 080f8df Oct 16, 2024
22 of 28 checks passed
@Swatinem Swatinem deleted the swatinem/merge-empty branch October 16, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants