Created prometheus handler class #790
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 442 443 +1
Lines 36597 36615 +18
=======================================
+ Hits 35869 35887 +18
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #790 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 442 443 +1
Lines 36597 36615 +18
=======================================
+ Hits 35869 35887 +18
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #790 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 442 443 +1
Lines 36597 36615 +18
=======================================
+ Hits 35869 35887 +18
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #790 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 442 443 +1
Lines 36597 36615 +18
=======================================
+ Hits 35869 35887 +18
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -17,79 +17,22 @@ | |||
| ) | |||
|
|
|||
| import sentry_sdk | |||
| from shared.metrics import Counter, Histogram, metrics | |||
| from shared.metrics import metrics | |||
There was a problem hiding this comment.
I guess you can also use the opportunity to remove all these statsd metrics
There was a problem hiding this comment.
I have a followup PR incoming, I'll remove them in that one 👌
We want to separate prometheus responsibilities from the checkpoint responsibilities to later extend its functionality. This PR just rearranges logic and doesn't include new one, to separate reviews into more manageable chunks.
This PR mainly creates the PrometheusCheckpointLoggerHandler class, which has log_X methods for logging X things. This class is then used in the checkpoint_logger.init.py file
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.