Refactor tests to use fixtures #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 98.00% 98.00% -0.01%
==========================================
Files 443 443
Lines 36566 36532 -34
==========================================
- Hits 35838 35804 -34
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 98.00% 98.00% -0.01%
==========================================
Files 443 443
Lines 36566 36532 -34
==========================================
- Hits 35838 35804 -34
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 98.00% 98.00% -0.01%
==========================================
Files 443 443
Lines 36566 36532 -34
==========================================
- Hits 35838 35804 -34
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is because the tests were failing on duplicate keys. Fixtures reuses existing objects, which avoids creating objects with duplicate keys.
Because pullid=1 was removed from the CommitFactory (due to unintended consequences of creating a Pull object), we now need to be explicit about setting it in a few places.
michelletran-codecov
force-pushed
the
pull_out_more_fixtures
branch
from
ccdd38b
to
8d85121
Compare
Swatinem
approved these changes
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 98.00% 98.00% -0.01%
==========================================
Files 443 443
Lines 36566 36532 -34
==========================================
- Hits 35838 35804 -34
Misses 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the tests were failing on duplicate keys. Fixtures reuses existing objects, which avoids creating objects with duplicate keys.
This was also extracted from #729 .
Also, since I also got rid of the Test Class, there's also a lot of white space changes. I would suggest selecting
Hide whitespacewhen reviewing this.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.