delete MetricContext, populate sentry tags from LogContext #818

matt-codecov · 2024-10-24T18:16:57Z

deletes MetricContext, cleans up usage of SQL metrics
- this should also eliminate some metric_context.populate() db queries although there were not many
adds LogContext fields to sentry tags
makes LogContext the decider of how its fields are added to log records and sentry tags
cleans up the redundant task_id and task_name log fields

codecov-notifications · 2024-10-24T18:23:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   98.02%   98.03%           
=======================================
  Files         442      442           
  Lines       36163    36113   -50     
=======================================
- Hits        35448    35402   -46     
+ Misses        715      711    -4

Flag	Coverage Δ
integration	`98.03% <100.00%> (+<0.01%)`	⬆️
unit	`98.03% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.92% <100.00%> (+0.01%)`	⬆️
OutsideTasks	`98.02% <100.00%> (+0.02%)`	⬆️

Files with missing lines	Coverage Δ
conftest.py	`94.73% <ø> (-0.27%)`	⬇️
helpers/log_context.py	`98.75% <100.00%> (+0.13%)`	⬆️
helpers/logging_config.py	`81.39% <100.00%> (-0.83%)`	⬇️
helpers/telemetry.py	`100.00% <100.00%> (+8.95%)`	⬆️
helpers/tests/unit/test_log_context.py	`100.00% <100.00%> (ø)`
helpers/tests/unit/test_logging_config.py	`100.00% <ø> (ø)`
helpers/tests/unit/test_telemetry.py	`100.00% <100.00%> (ø)`
services/report/__init__.py	`97.05% <100.00%> (-0.01%)`	⬇️
tasks/base.py	`95.80% <100.00%> (-0.10%)`	⬇️
tasks/label_analysis.py	`99.11% <100.00%> (-0.02%)`	⬇️
... and 5 more

... and 1 file with indirect coverage changes

codecov-qa · 2024-10-24T18:23:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (79f57df) to head (abce040).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   98.02%   98.03%           
=======================================
  Files         442      442           
  Lines       36163    36113   -50     
=======================================
- Hits        35448    35402   -46     
+ Misses        715      711    -4

Flag	Coverage Δ
integration	`98.03% <100.00%> (+<0.01%)`	⬆️
unit	`98.03% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.92% <100.00%> (+0.01%)`	⬆️
OutsideTasks	`98.02% <100.00%> (+0.02%)`	⬆️

Files with missing lines	Coverage Δ
conftest.py	`94.73% <ø> (-0.27%)`	⬇️
helpers/log_context.py	`98.75% <100.00%> (+0.13%)`	⬆️
helpers/logging_config.py	`81.39% <100.00%> (-0.83%)`	⬇️
helpers/telemetry.py	`100.00% <100.00%> (+8.95%)`	⬆️
helpers/tests/unit/test_log_context.py	`100.00% <100.00%> (ø)`
helpers/tests/unit/test_logging_config.py	`100.00% <ø> (ø)`
helpers/tests/unit/test_telemetry.py	`100.00% <100.00%> (ø)`
services/report/__init__.py	`97.05% <100.00%> (-0.01%)`	⬇️
tasks/base.py	`95.80% <100.00%> (-0.10%)`	⬇️
tasks/label_analysis.py	`99.11% <100.00%> (-0.02%)`	⬇️
... and 5 more

... and 1 file with indirect coverage changes

codecov · 2024-10-24T18:23:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (79f57df) to head (abce040).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   98.02%   98.03%           
=======================================
  Files         442      442           
  Lines       36163    36113   -50     
=======================================
- Hits        35448    35402   -46     
+ Misses        715      711    -4

Flag	Coverage Δ
integration	`98.03% <100.00%> (+<0.01%)`	⬆️
unit	`98.03% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.92% <100.00%> (+0.01%)`	⬆️
OutsideTasks	`98.02% <100.00%> (+0.02%)`	⬆️

Files with missing lines	Coverage Δ
conftest.py	`94.73% <ø> (-0.27%)`	⬇️
helpers/log_context.py	`98.75% <100.00%> (+0.13%)`	⬆️
helpers/logging_config.py	`81.39% <100.00%> (-0.83%)`	⬇️
helpers/telemetry.py	`100.00% <100.00%> (+8.95%)`	⬆️
helpers/tests/unit/test_log_context.py	`100.00% <100.00%> (ø)`
helpers/tests/unit/test_logging_config.py	`100.00% <ø> (ø)`
helpers/tests/unit/test_telemetry.py	`100.00% <100.00%> (ø)`
services/report/__init__.py	`97.05% <100.00%> (-0.01%)`	⬇️
tasks/base.py	`95.80% <100.00%> (-0.10%)`	⬇️
tasks/label_analysis.py	`99.11% <100.00%> (-0.02%)`	⬇️
... and 5 more

... and 1 file with indirect coverage changes

codecov-public-qa · 2024-10-24T18:23:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (79f57df) to head (abce040).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   98.02%   98.03%           
=======================================
  Files         442      442           
  Lines       36163    36113   -50     
=======================================
- Hits        35448    35402   -46     
+ Misses        715      711    -4

Flag	Coverage Δ
integration	`98.03% <100.00%> (+<0.01%)`	⬆️
unit	`98.03% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.92% <100.00%> (+0.01%)`	⬆️
OutsideTasks	`98.02% <100.00%> (+0.02%)`	⬆️

Files	Coverage Δ
conftest.py	`94.73% <ø> (-0.27%)`	⬇️
helpers/log_context.py	`98.75% <100.00%> (+0.13%)`	⬆️
helpers/logging_config.py	`81.39% <100.00%> (-0.83%)`	⬇️
helpers/telemetry.py	`100.00% <100.00%> (+8.95%)`	⬆️
helpers/tests/unit/test_log_context.py	`100.00% <100.00%> (ø)`
helpers/tests/unit/test_logging_config.py	`100.00% <ø> (ø)`
helpers/tests/unit/test_telemetry.py	`100.00% <100.00%> (ø)`
services/report/__init__.py	`97.05% <100.00%> (-0.01%)`	⬇️
tasks/base.py	`95.80% <100.00%> (-0.10%)`	⬇️
tasks/label_analysis.py	`99.11% <100.00%> (-0.02%)`	⬇️
... and 5 more

... and 1 file with indirect coverage changes

Swatinem · 2024-10-28T09:11:57Z

helpers/log_context.py

+    def add_to_sentry(self):
+        d = self.as_dict()
+        d.pop("sentry_trace_id", None)
+        sentry_sdk.set_tags(d)


Interesting, I see set_tags as a Scope API, but not as part of the top level APIs.

Maybe this is just an oversight in the docs? CC @antonpirker

Swatinem · 2024-10-28T09:14:29Z

helpers/telemetry.py

+    `log_simple_metric()`, meaning it will throw logging on the
    asyncio queue and then immediately return without needing to be awaited. Can


as this is now using a ContextVar, is that guaranteed to be more consistent than a global which might change underneath?

y'know, good question. i think so; as i understand it the context will inherit a clone of the parent context so the parent context is free to change

delete MetricContext, populate sentry tags from LogContext

5cc972a

matt-codecov requested a review from a team October 24, 2024 18:23

Swatinem approved these changes Oct 28, 2024

View reviewed changes

matt-codecov mentioned this pull request Oct 28, 2024

[open-ended] brainstorm what information we can/should tag on sentry traces codecov/engineering-team#2024

Open

Merge branch 'main' into pr818

abce040

matt-codecov enabled auto-merge October 28, 2024 16:56

matt-codecov added this pull request to the merge queue Oct 28, 2024

Merged via the queue into main with commit f06e233 Oct 28, 2024
26 of 27 checks passed

matt-codecov deleted the pr818 branch October 28, 2024 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

delete MetricContext, populate sentry tags from LogContext #818

delete MetricContext, populate sentry tags from LogContext #818

matt-codecov commented Oct 24, 2024 •

edited

Loading

codecov-notifications bot commented Oct 24, 2024 •

edited

Loading

codecov-qa bot commented Oct 24, 2024 •

edited

Loading

codecov bot commented Oct 24, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 24, 2024 •

edited

Loading

Swatinem Oct 28, 2024

Swatinem Oct 28, 2024

matt-codecov Oct 28, 2024

		`log_simple_metric()`, meaning it will throw logging on the
		asyncio queue and then immediately return without needing to be awaited. Can

delete MetricContext, populate sentry tags from LogContext #818

delete MetricContext, populate sentry tags from LogContext #818

Conversation

matt-codecov commented Oct 24, 2024 • edited Loading

codecov-notifications bot commented Oct 24, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Oct 24, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 24, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Oct 24, 2024 • edited Loading

Codecov Report

Swatinem Oct 28, 2024

Choose a reason for hiding this comment

Swatinem Oct 28, 2024

Choose a reason for hiding this comment

matt-codecov Oct 28, 2024

Choose a reason for hiding this comment

matt-codecov commented Oct 24, 2024 •

edited

Loading

codecov-notifications bot commented Oct 24, 2024 •

edited

Loading

codecov-qa bot commented Oct 24, 2024 •

edited

Loading

codecov bot commented Oct 24, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 24, 2024 •

edited

Loading