Only request a single RepoProvider in Notify task #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 441 441
Lines 36087 36042 -45
==========================================
- Hits 35376 35330 -46
- Misses 711 712 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 441 441
Lines 36087 36042 -45
==========================================
- Hits 35376 35330 -46
- Misses 711 712 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 441 441
Lines 36087 36042 -45
==========================================
- Hits 35376 35330 -46
- Misses 711 712 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 441 441
Lines 36087 36042 -45
==========================================
- Hits 35376 35330 -46
- Misses 711 712 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Oct 29, 2024
Previously, the Notify task would get a repo provider token multiple times. In the task itself, in the `ComparisonProxy`, and in each one of the configured checks. This will now make sure to only get the repo provider once, and thread it through to all of its use-sites.
Swatinem
force-pushed
the
swatinem/one-notify-provider
branch
from
a2b6737
to
1c9d875
Compare
Swatinem
force-pushed
the
swatinem/one-notify-provider
branch
from
5a37708
to
124c78f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Notify task would get a repo provider token multiple times. In the task itself, in the
ComparisonProxy, and in each one of the configured checks.This will now make sure to only get the repo provider once, and thread it through to all of its use-sites.
Fixes part of codecov/engineering-team#2760