move repo.updatestamp update from Upload to UploadFinisher

[matt-codecov]

this is a low-hanging fruit for reducing database locking. instead of doing this write in the repos table for every UploadTask, let's do it for UploadFinisher which should run less

that said, the UploadFinisher task will hold the lock longer

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/upload_finisher.py

Function	Unhandled Issue
run_impl	TypeError: string indices must be integers, not 'str' app.tasks.upload.UploadFin... Event Count: 4

---

_{Did you find this useful? React with a 👍 or 👎}

[codecov-staging]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36113    36112       -1     
==========================================
- Hits        35402    35401       -1     
  Misses        711      711              

Flag	Coverage Δ
integration	98.03% <100.00%> (-0.01%)	⬇️
unit	98.03% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	95.92% <100.00%> (ø)
OutsideTasks	98.02% <ø> (ø)

Files with missing lines	Coverage Δ
tasks/tests/unit/test_upload_task.py	98.94% <ø> (-0.01%)	⬇️
tasks/upload.py	96.49% <ø> (-0.03%)	⬇️
tasks/upload_finisher.py	96.72% <100.00%> (+0.03%)	⬆️

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f06e233) to head (3fb3283).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36113    36112       -1     
==========================================
- Hits        35402    35401       -1     
  Misses        711      711              

Flag	Coverage Δ
integration	98.03% <100.00%> (-0.01%)	⬇️
unit	98.03% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	95.92% <100.00%> (ø)
OutsideTasks	98.02% <ø> (ø)

Files with missing lines	Coverage Δ
tasks/tests/unit/test_upload_task.py	98.94% <ø> (-0.01%)	⬇️
tasks/upload.py	96.49% <ø> (-0.03%)	⬇️
tasks/upload_finisher.py	96.72% <100.00%> (+0.03%)	⬆️

[codecov-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f06e233) to head (3fb3283).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36113    36112       -1     
==========================================
- Hits        35402    35401       -1     
  Misses        711      711              

Flag	Coverage Δ
integration	98.03% <100.00%> (-0.01%)	⬇️
unit	98.03% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	95.92% <100.00%> (ø)
OutsideTasks	98.02% <ø> (ø)

Files with missing lines	Coverage Δ
tasks/tests/unit/test_upload_task.py	98.94% <ø> (-0.01%)	⬇️
tasks/upload.py	96.49% <ø> (-0.03%)	⬇️
tasks/upload_finisher.py	96.72% <100.00%> (+0.03%)	⬆️

[codecov-public-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f06e233) to head (3fb3283).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36113    36112       -1     
==========================================
- Hits        35402    35401       -1     
  Misses        711      711              

Flag	Coverage Δ
integration	98.03% <100.00%> (-0.01%)	⬇️
unit	98.03% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	95.92% <100.00%> (ø)
OutsideTasks	98.02% <ø> (ø)

Files	Coverage Δ
tasks/tests/unit/test_upload_task.py	98.94% <ø> (-0.01%)	⬇️
tasks/upload.py	96.49% <ø> (-0.03%)	⬇️
tasks/upload_finisher.py	96.72% <100.00%> (+0.03%)	⬆️