Add metrics for intermediate Report size #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emits metrics for uncompressed and `zstd` compressed intermediate Reports. Saving these to GCS is slow and might also be expensive. Saving them to a more transient storage such as redis should be a lot faster and potentially cheaper as well. However, such intermediate storage might be a lot more size constraint, so we want to figure out what we are dealing with. In addition, this also cleans up a bunch of leftover code after fully rolling out parallel processing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 442 441 -1
Lines 36112 36112
=======================================
Hits 35401 35401
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 442 441 -1
Lines 36112 36112
=======================================
Hits 35401 35401
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 442 441 -1
Lines 36112 36112
=======================================
Hits 35401 35401
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 442 441 -1
Lines 36112 36112
=======================================
Hits 35401 35401
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adrian-codecov
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emits metrics for uncompressed and
zstdcompressed intermediate Reports.Saving these to GCS is slow and might also be expensive. Saving them to a more transient storage such as redis should be a lot faster and potentially cheaper as well. However, such intermediate storage might be a lot more size constraint, so we want to figure out what we are dealing with.
In addition, this also cleans up a bunch of leftover code after fully rolling out parallel processing.