Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop tracking onboarding metrics #831

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Fix DB perf issues. We also gained intended insight from this metric in terms of understanding a user signup- > completed upload ratio.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f701e3f) to head (02d0867).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36112    36103       -9     
==========================================
- Hits        35401    35392       -9     
  Misses        711      711              
Flag Coverage Δ
integration 98.03% <100.00%> (-0.01%) ⬇️
unit 98.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (-0.01%) ⬇️
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
django_scaffold/settings.py 0.00% <ø> (ø)
tasks/tests/unit/test_upload_task.py 98.93% <100.00%> (-0.02%) ⬇️
tasks/upload.py 96.46% <ø> (-0.03%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f701e3f) to head (02d0867).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36112    36103       -9     
==========================================
- Hits        35401    35392       -9     
  Misses        711      711              
Flag Coverage Δ
integration 98.03% <100.00%> (-0.01%) ⬇️
unit 98.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (-0.01%) ⬇️
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
django_scaffold/settings.py 0.00% <ø> (ø)
tasks/tests/unit/test_upload_task.py 98.93% <100.00%> (-0.02%) ⬇️
tasks/upload.py 96.46% <ø> (-0.03%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36112    36103       -9     
==========================================
- Hits        35401    35392       -9     
  Misses        711      711              
Flag Coverage Δ
integration 98.03% <100.00%> (-0.01%) ⬇️
unit 98.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (-0.01%) ⬇️
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
django_scaffold/settings.py 0.00% <ø> (ø)
tasks/tests/unit/test_upload_task.py 98.93% <100.00%> (-0.02%) ⬇️
tasks/upload.py 96.46% <ø> (-0.03%) ⬇️

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f701e3f) to head (02d0867).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36112    36103       -9     
==========================================
- Hits        35401    35392       -9     
  Misses        711      711              
Flag Coverage Δ
integration 98.03% <100.00%> (-0.01%) ⬇️
unit 98.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (-0.01%) ⬇️
OutsideTasks 98.02% <ø> (ø)
Files Coverage Δ
django_scaffold/settings.py 0.00% <ø> (ø)
tasks/tests/unit/test_upload_task.py 98.93% <100.00%> (-0.02%) ⬇️
tasks/upload.py 96.46% <ø> (-0.03%) ⬇️

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit b3c7119 Oct 29, 2024
26 of 27 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/remove-onboarding-metrics branch October 29, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants