Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less repo timestamp updates #842

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Less repo timestamp updates #842

merged 2 commits into from
Oct 31, 2024

Conversation

trent-codecov
Copy link
Contributor

Only update the timestamp IF other fields change. This will help immensely with DB lock contention.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/sync_repos.py 60.00% 6 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   98.04%   98.03%   -0.02%     
==========================================
  Files         444      444              
  Lines       36064    36083      +19     
==========================================
+ Hits        35360    35373      +13     
- Misses        704      710       +6     
Flag Coverage Δ
integration 98.03% <60.00%> (-0.02%) ⬇️
unit 98.03% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.98% <60.00%> (-0.04%) ⬇️
OutsideTasks 98.06% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
tasks/sync_repos.py 94.81% <60.00%> (-2.72%) ⬇️

... and 1 file with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (4ab80f2) to head (aa812ed).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/sync_repos.py 60.00% 6 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   98.04%   98.03%   -0.02%     
==========================================
  Files         444      444              
  Lines       36064    36083      +19     
==========================================
+ Hits        35360    35373      +13     
- Misses        704      710       +6     
Flag Coverage Δ
integration 98.03% <60.00%> (-0.02%) ⬇️
unit 98.03% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.98% <60.00%> (-0.04%) ⬇️
OutsideTasks 98.06% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
tasks/sync_repos.py 94.81% <60.00%> (-2.72%) ⬇️

... and 1 file with indirect coverage changes

@trent-codecov trent-codecov added this pull request to the merge queue Oct 31, 2024
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (4ab80f2) to head (aa812ed).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   98.04%   98.03%   -0.02%     
==========================================
  Files         444      444              
  Lines       36064    36083      +19     
==========================================
+ Hits        35360    35373      +13     
- Misses        704      710       +6     
Flag Coverage Δ
integration 98.03% <60.00%> (-0.02%) ⬇️
unit 98.03% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.98% <60.00%> (-0.04%) ⬇️
OutsideTasks 98.06% <ø> (+<0.01%) ⬆️
Files Coverage Δ
tasks/sync_repos.py 94.81% <60.00%> (-2.72%) ⬇️

... and 1 file with indirect coverage changes

Merged via the queue into main with commit 9c70365 Oct 31, 2024
17 of 23 checks passed
@trent-codecov trent-codecov deleted the trent/add-make-shell branch October 31, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants