Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

904 update django dependency #846

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

adrian-codecov
Copy link
Contributor

@adrian-codecov adrian-codecov commented Nov 2, 2024

Updating django as there are vuln tickets

https://github.com/codecov/internal-issues/issues/904
https://github.com/codecov/internal-issues/issues/905

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (8fec23c) to head (4ed5e4c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         444      444           
  Lines       36003    36003           
=======================================
  Hits        35292    35292           
  Misses        711      711           
Flag Coverage Δ
integration 98.02% <ø> (ø)
unit 98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.05% <ø> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         444      444           
  Lines       36003    36003           
=======================================
  Hits        35292    35292           
  Misses        711      711           
Flag Coverage Δ
integration 98.02% <ø> (ø)
unit 98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.05% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (8fec23c) to head (4ed5e4c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         444      444           
  Lines       36003    36003           
=======================================
  Hits        35292    35292           
  Misses        711      711           
Flag Coverage Δ
integration 98.02% <ø> (ø)
unit 98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.05% <ø> (ø)

Copy link

codecov-public-qa bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (8fec23c) to head (4ed5e4c).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         444      444           
  Lines       36003    36003           
=======================================
  Hits        35292    35292           
  Misses        711      711           
Flag Coverage Δ
integration 98.02% <ø> (ø)
unit 98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <ø> (ø)
OutsideTasks 98.05% <ø> (ø)

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to just bump all the dependencies (maybe on a regular schedule) to the latest semver compatible version?

@adrian-codecov
Copy link
Contributor Author

@Swatinem we've have dependabot on other repos to keep up-to-date ish, we could probably add that here as well

@adrian-codecov adrian-codecov added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 77eac6f Nov 4, 2024
39 of 40 checks passed
@adrian-codecov adrian-codecov deleted the 904-update-django-dependency branch November 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants