Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove get_existing_tests from test process #853

Merged
merged 4 commits into from
Nov 7, 2024
Merged

fix: remove get_existing_tests from test process #853

merged 4 commits into from
Nov 7, 2024

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Nov 5, 2024 •
edited
Loading

this query is very slow and we don't necessarily need it, a side effect is that this will mean the insert on conflict do nothing will contain rows that it doesn't need to but that's fine

depends on: codecov/shared#414

@joseph-sentry
fix: remove get_existing_tests from test process
d12c910 
this query is very slow and we don't necessarily need it, a side effect
is that this will mean the insert on conflict do nothing will contain
rows that it doesn't need to but that's fine
@joseph-sentry joseph-sentry requested a review from a team November 5, 2024 18:30
@codecov-staging
Copy link

codecov-staging bot commented Nov 5, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   98.01%   98.01%   -0.01%     
==========================================
  Files         445      445              
  Lines       36099    36094       -5     
==========================================
- Hits        35384    35379       -5     
  Misses        715      715
Flag Coverage Δ
integration 98.01% <100.00%> (-0.01%) ⬇️
unit 98.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.05% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.11% <100.00%> (-0.07%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (f6f66e8) to head (12baffc).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   98.01%   98.01%   -0.01%     
==========================================
  Files         445      445              
  Lines       36099    36094       -5     
==========================================
- Hits        35384    35379       -5     
  Misses        715      715
Flag Coverage Δ
integration 98.01% <100.00%> (-0.01%) ⬇️
unit 98.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.05% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.11% <100.00%> (-0.07%) ⬇️

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (f6f66e8) to head (12baffc).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   98.01%   98.01%   -0.01%     
==========================================
  Files         445      445              
  Lines       36099    36094       -5     
==========================================
- Hits        35384    35379       -5     
  Misses        715      715
Flag Coverage Δ
integration 98.01% <100.00%> (-0.01%) ⬇️
unit 98.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.05% <ø> (ø)
Files Coverage Δ
tasks/test_results_processor.py 97.11% <100.00%> (-0.07%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (f6f66e8) to head (12baffc).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   98.01%   98.01%   -0.01%     
==========================================
  Files         445      445              
  Lines       36099    36094       -5     
==========================================
- Hits        35384    35379       -5     
  Misses        715      715
Flag Coverage Δ
integration 98.01% <100.00%> (-0.01%) ⬇️
unit 98.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.05% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.11% <100.00%> (-0.07%) ⬇️

adrian-codecov
adrian-codecov approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a test file affected by this?

@joseph-sentry
Merge branch 'main' of github.com:codecov/worker into joseph/remove-q…
8c35dac 
…uery
@joseph-sentry
deps: update shared
978cde4 
because we need the unique constraint on test flag bridge
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

This PR includes changes to shared. Please review them here: codecov/shared@83b3376...6958f32

@joseph-sentry
Copy link
Contributor Author

Should there be a test file affected by this?

no, this change is internal to the test results processor task

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit d2a2115 Nov 7, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/remove-query branch November 7, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-codecov adrian-codecov adrian-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @adrian-codecov