Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize update_commit_from_provider_info #855

Merged
merged 3 commits into from
Nov 7, 2024

add more typing

4bfca43
Select commit
Loading
Failed to load commit list.
Merged

Optimize update_commit_from_provider_info #855

add more typing
4bfca43
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 6, 2024 in 0s

98.01% (-0.02%) compared to 1e2c27a

View this Pull Request on Codecov

98.01% (-0.02%) compared to 1e2c27a

Details

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.01%. Comparing base (1e2c27a) to head (4bfca43).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/repository.py 98.18% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.02%     
==========================================
  Files         444      445       +1     
  Lines       36057    36102      +45     
==========================================
+ Hits        35346    35386      +40     
- Misses        711      716       +5     
Components Coverage Δ
NonTestCode 96.00% <98.27%> (+0.02%) ⬆️
OutsideTasks 98.05% <98.18%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
tasks/commit_update.py 100.00% <100.00%> (ø)
tasks/preprocess_upload.py 98.11% <100.00%> (-0.04%) ⬇️
tasks/tests/unit/test_upload_task.py 98.92% <ø> (ø)
tasks/upload.py 96.51% <100.00%> (ø)
services/repository.py 96.21% <98.18%> (-0.35%) ⬇️

... and 21 files with indirect coverage changes